1817877 - Stop using DeferredTask to delay the one-off initialization of content-process telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[:Gijs (he/him)]

bug 1645862 added some comment here:

    // FIXME: This is a terrible abuse of DeferredTask.

Although pointedly phrased, it does seem sad that this is causing us to import yet another module on content process startup. DeferredTask is there to debounce multiple calls during the timeout period, and there is only one caller (from the observer notification content-process-ready-for-script which only fires once), so it isn't needed here.

This appears to be the only content-process use of DeferredTask on startup.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1817877 - stop using DeferredTask in TelemetryControllerContent.sys.mjs, r?chutten,dexter

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b7f0ab79790
stop using DeferredTask in TelemetryControllerContent.sys.mjs, r=chutten

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6b7f0ab79790

Comment 4

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b7f0ab79790
stop using DeferredTask in TelemetryControllerContent.sys.mjs, r=chutten

== Change summary for alert #37346 (as of Mon, 27 Feb 2023 11:21:39 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.36%	Base Content JS	macosx1015-64-shippable-qr	fission	1,653,944.00 -> 1,647,984.00
0.36%	Base Content JS	macosx1015-64-shippable-qr	fission	1,653,936.00 -> 1,647,960.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37346