Open Bug 1818050 Opened 2 years ago

Move the popupnotification elements into a html:template tag

Categories

(Toolkit :: UI Widgets, task)

task

Tracking

()

People

(Reporter: tgiles, Unassigned)

Details

As part of Bug 1813077, Gijs asked for this follow up bug to be filed.

See this patch for full context:

Then please file a follow-up bug to put the popupnotification elements in a html:template tag so they don't become part of the live DOM immediately. That will take a bit of work because it means that anything that hardcode references to the IDs in the popup notifications from JS will need to ensure those are only evaluated after the elements get taken out of the html:template tag - see e.g. deps of Bug 1634030 .
At that point it should be possible to move a bunch of these strings into a separate ftl file (like popup-notifications.ftl) and load that "just in time" like popupnotification.ftl (note: that file is in toolkit and this markup is in browser/ code, so it probably wants its own ftl file). This would be better for performance all around - both for not creating DOM for stuff we're not using, and not loading l10n for things we're not using.

You need to log in before you can comment on or make changes to this bug.