1818165 - The checked state of Quick Filter Bar menuitems is out of sync with the actual visibility status ([≡ >] View > Toolbars > Quick Filter Bar)

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Sören Hentzschel]

STR:

1. Click View > Toolbars in the menu bar

Expected:

• There is a checkmark before "Quick Filter Bar" if the quick filter bar is enabled
• There is no checkmark before "Quick Filter Bar" if the quick filter bar is disabled

Actual:

• There is no checkmark before "Quick Filter Bar" if the quick filter bar is enabled
• There is a checkmark before "Quick Filter Bar" if the quick filter bar is disabled

Tested in 112.0a1 (2023-02-21) on macOS 13.2.

Comment 1

[Thomas D. (:thomas8)]

Add [Supernova] to Whiteboard 20230222_1327

Comment 2

[Thomas D. (:thomas8)]

Thanks Sören! Nice bug report. For bonus points, kindly present Actual Result before Expected Result because that's what the guidelines say, so we're used to that and it makes sense if you think about it. Terminology: We use enable/disable for "greying out" of commands, so here it's about checked vs. unchecked.

Confirming for 112.0a1 (2023-02-22) (64-bit).
The checked state of the following two menus is completely random and dissociated from the actual visibility of the QFB. The toolbar button seems to stay in sync well.

• Main menu: View > Toolbars > Quick Filter Bar (QFB)
• App menu: ≡ > View > Toolbars > Quick Filter Bar

The checked state of both menus must be updated for the following scenarios:

• using keyboard shortcut Ctrl+Shift+K to show QFB (as a caveat, this can also be used to just focus the already visible QFB, so the shortcut will not always toggle the visibility state).
• pressing ESC to hide QFB
• clicking toolbar button to show/hide QFB
• using menu to show/hide QFB (hopefully, the checkmark would update automatically for this scenario)

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1818165 - Correctly set Quick Filter Bar menu item. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ee7d264b796
Correctly set Quick Filter Bar menu item. r=mkmelin

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9320684 [details]
Bug 1818165 - Correctly set Quick Filter Bar menu item. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/9e6dbc2b186a