1818166 - Hidden Quick Filter Bar keeps coming back after restarting TB

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Sören Hentzschel]

STR:

1. Click View > Toolbars > Quick Filter Bar in the menu bar
2. Exit Thunderbird
3. Start Thunderbird

Expected:

The quick filter bar is disabled after step 1 and remain disabled after step 3.

Actual:

The quick filter bar is disabled after step 1 but is enabled again after step 3.

Tested in 112.0a1 (2023-02-21) on macOS 13.2.

Comment 1

[Thomas D. (:thomas8)]

Add [Supernova] to Whiteboard 20230222_1327

Comment 2

[Thomas D. (:thomas8)]

Confirming for 112.0a1 (2023-02-22) (64-bit).

STR

• Hide Quick Filter bar
• Exit Thunderbird
• Restart Thunderbird

Actual

• Quick filter bar is shown again after restarting TB

Expected

• Quick filter bar should remain hidden after restarting TB

Comment 3

[Wayne Mery (:wsmwk)]

Triggering on restart does not correlate to the inconsistent state of the menu item as noted bug 1818165?

Comment 4

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #3)

Triggering on restart does not correlate to the inconsistent state of the menu item as noted bug 1818165?

Possible, but unlikely. I would think that the menus are just not updated (which used to be automatical via XUL command attributes), whereas the state of the filter bar would be persisted in some other, more direct ways, e.g. through persist attribute on the bar if we still have that.
But I forgot to link the two bugs, thanks.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1818166 - Store the visibility state of the Quick Filter bar in the XUL store. r=#thunderbird-front-end-reviewers

This information used to be stored differently due to the complicated way the QFB was implemented. I don't think replicating that is worth it, so I've kept things simple.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ea28213fbdcd
Store the visibility state of the Quick Filter bar in the XUL store. r=aleca

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9329218 [details]
Bug 1818166 - Store the visibility state of the Quick Filter bar in the XUL store. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 113.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/a8514252a7b0