1818198 - Do not record credit card form detected event telemetry when the form is not considered as a valid cc form

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Dimi Lee [ooo 16.04 - 21.04］]

We record credit card detect event telemetry even when a credit card section is invalid.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1801039

Comment 2

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 1818198 - Record form detect event telemetry only after we're sure this is a valid form r=#credential-management-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/363429f0a2eb
Record form detect event telemetry only after we're sure this is a valid form r=credential-management-reviewers,sgalich

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/363429f0a2eb

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dimi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 9319326 [details]
Bug 1818198 - Record form detect event telemetry only after we're sure this is a valid form r=#credential-management-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: No. This patch only affects how we collect telemetry. Uplift this patch ensure telemetry collected in Fx111 is correct
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low, this patch only changes when we collect telemetry
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9319326 [details]
Bug 1818198 - Record form detect event telemetry only after we're sure this is a valid form r=#credential-management-reviewers

Approved for 111.0b7

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dd33da2f087b