1818321 - Search engine parity - manual adjustments

Status: VERIFIED FIXED

(Firefox for Android :: General, enhancement, P2)

Description

[Joe M [:jmahon]]

Search engine parity - manual adjustments

If the results of the config audit script give us insight into some easy adjustments to make, or some differences that are particularly risky, we should just manually make these changes to patch up the differences between Android and Desktop search.

Comment 1

[[:skhan]]

As mentioned in the comments section on the hierarchy up : https://bugzilla.mozilla.org/show_bug.cgi?id=1818320 , we need to add a few missing engines to a few locales in the semi-alphabetical order i.e : first the default search engine, and then the rest in alphabetical order. Does this sound correct? (:standard8)
Attaching the list here as well.

Locale and Engine(s) to be added

an -> ebay-es
ast -> ebay-es
ca -> ebay-es
cy -> ebay-uk
eu -> ebay-es
fr -> ebay-fr
fy-NL -> ebay-nl
ga-IE -> ebay-ie
gd -> ebay-uk
gl -> ebay-es
ja -> rakuten, yahoo-jp-auctions
nl -> ebay-nl
rm -> ebay-ch
wo -> ebay-fr

Comment 2

[Mark Banner (:standard8)]

(In reply to [:skhan] from comment #1)

As mentioned in the comments section on the hierarchy up : https://bugzilla.mozilla.org/show_bug.cgi?id=1818320 , we need to add a few missing engines to a few locales in the semi-alphabetical order i.e : first the default search engine, and then the rest in alphabetical order. Does this sound correct? (:standard8)

Yes, I think that should be fine.

Attaching the list here as well.

The list looks good.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1818321 - Update missing default engines (#3646)

Comment 4

[[:skhan]]

I missed adding "uk" to the list. It is there in the spreadsheet.
uk -> bing

Also, (:standard8), I erroneously added bing in the spreadsheet to "ca". It is not there and I wanted to ask if we should?

Comment 5

[Mark Banner (:standard8)]

To clarify the above comment, I think this is the new list:

an -> ebay-es
ast -> ebay-es
ca -> bing, ebay-es
cy -> ebay-uk
eu -> ebay-es
fr -> ebay-fr
fy-NL -> ebay-nl
ga-IE -> ebay-ie
gd -> ebay-uk
gl -> ebay-es
ja -> rakuten, yahoo-jp-auctions
nl -> ebay-nl
uk -> bing
rm -> ebay-ch
wo -> ebay-fr

If so, then we're good to add them.

Comment 6

[Mark Banner (:standard8)]

We've also been asked by BD to add Bing to the Turkish locale (tr).

Comment 7

[[:skhan]]

Attachment: Mobile/Desktop Parity - sheet2

On reviews, it came up the script run to develop this sheet was yielding different than the correct results for a few locales (15) causing it to add the "bing" search engine. The list is revised to a completed different one and the locales when error was prevalent have been marked "Updated".
(:standard8) Sorry to cause trouble again but can you please have another look at these updated sheet? (Only the updated locales needed)

Comment 8

[Mark Banner (:standard8)]

I've just confirmed that we can add Bing in the additional places.

Comment 9

[BMO Github Automation]

Authored by https://github.com/sarah541
https://github.com/mozilla-mobile/firefox-android/commit/5aac35da96f041c8f78358fd44e8af87cd35a46d
[main] Bug 1818321 - Update missing default engines

Comment 10

[Lorand Janos]

Hi, could you help QA verify this issue with STR? or any areas, scenarios to check? Thank you!

Comment 11

[Mira Lobontiu (Android QA)]

Verified on the latest Fenix Nightly 122.0a1 from 11/22 with Oppo Find N2 Flip (Android 13), that the languages from the list have the "Bing" & "Ebay" search engines as default.

Comment 12

[[:skhan]]

Thank you for testing this! I hope we were also able to test the newly added search engines "rakuten" and "yahoo-jp-auctions" for the locale "ja"

Comment 13

[[:skhan]]

Got the answer to my other question which was fixed as a separate bug https://bugzilla.mozilla.org/show_bug.cgi?id=1858528 and tested there