1818437 - RTAMO onboarding page design is cut at the bottom along with the “Not Now” button

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Alex Cornestean]

Attachment: 2023-02-23_09h12_00.png

Affected versions:

• Nightly (112.0a1/20230222214030)
• Beta (111.0b4/20230221190142)

Description:
The RTAMO onboarding page design is cut at the bottom and along with it, the “Not Now” button. A small portion of the upper part of the button is still visible and can be clicked to expand the address bar i.e. functionality is not affected.

Steps to reproduce:

1. While using a VM with Windows, launch Edge or Chrome and access https://addons.mozilla.org
2. On AMO, access the page of any add-on and click the “Download Firefox and get the extension” button
3. Once the installer is downloaded, run it to install Firefox (This will install the latest Firefox Release 110.0)
4. After installation Firefox Release will launch and the RTAMO onboarding page will be displayed, the “Not Now” button being fully visible and none of the page contents being cut.
5. Open the installation folder of Firefox Release, locate the “postSigningData” file and copy it to Desktop.
6. Download and install the latest Firefox Nightly 112.0a1 and Firefox Beta 111.0b4
7. Open the installation folders of Nightly and Beta and paste the previously copied “postSigningData” file inside the folders.
8. Launch both Nightly and Beta and access about:welcome on the browsers
9. The RTAMO onboarding page will be displayed on both browsers, but the page design will be cut at the bottom along with the “Not Now” button. The upper part of the button is still visible and can be clicked.

Actual:
RTAMO onboarding page design is cut at the bottom along with the “Not Now” button.

Expected:
The RTAMO onboarding page contents are fully displayed.

Comment 1

[Alex Cornestean]

Need to re-iterate that Firefox Release 110.0 is not affected. See the attached screenshot.

Comment 2

[Alex Cornestean]

Attachment: 2023-02-23_09h12_13.png

Comment 3

[Emily McMinn :emcminn]

Hi, thanks for the catch! This is due to the removal of the progress bar for single screen messages in 1796238 and should be fixed by the patch for 1811069, which should land soon :)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1796238

Comment 5

[Shane Hughes [:aminomancer]]

Fixed by bug 1811069

Comment 6

[Alex Cornestean]

I attempted to verify the issue and although bug 1811069 appears to have landed in Nightly (checked via about:buildconfig which shows the patch is landed in the latest Nightly), the RTAMO about:welcome page in Nightly is the same as before – cut at the bottom along with the “Not Now” button.

I checked three times via the original STR above to be sure, and the issue still exists in the latest Nightly (112.0a1/20230226214053) where it should have been fixed.

I will not reopen the bug yet, until maybe some further info is provided as to why the issue is still occurring.

Thank you !

Comment 7

[Alex Cornestean]

Attachment: 2023-02-27_12h11_57.png

Comment 8

[Shane Hughes [:aminomancer]]

(In reply to Alex Cornestean from comment #6)

I attempted to verify the issue and although bug 1811069 appears to have landed in Nightly (checked via about:buildconfig which shows the patch is landed in the latest Nightly), the RTAMO about:welcome page in Nightly is the same as before – cut at the bottom along with the “Not Now” button.

I checked three times via the original STR above to be sure, and the issue still exists in the latest Nightly (112.0a1/20230226214053) where it should have been fixed.

I will not reopen the bug yet, until maybe some further info is provided as to why the issue is still occurring.

Thank you !

Thanks for taking the time to test this. My mistake - Emily actually reverted her patch to remove the changes that fixed this because they were causing animation problems, and it just slipped my mind. We can try a more conservative route. It seems there is a major oversight in the component code that we ought to fix anyway. totalNumberOfScreens is used by ReturnToAMO but not provided anywhere as far as I can tell. There are some other misplaced properties too, I think. It's kinda hard to know since I'm not sure how to see all the possible attribution code that exists. I'll try to fix them all in one go. This whole thing is really my fault anyway since I didn't bother testing RTAMO while I was reviewing the code that changed how we hide/show the progress bar. It's too tedious to test in a local build. But I found a way to kinda fake it, so I'll try to be more conscientious of RTAMO in the future.

Comment 9

[Shane Hughes [:aminomancer]]

Attachment: Bug 1818437 - Fix RTAMO page to account for its having a single screen

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc4e81050519
Fix RTAMO page to account for its having a single screen r=aminomancer

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dc4e81050519

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[William Durand [:willdurand]]

Isn't this bug going to affect release users? Could we consider a beta uplift?

Comment 14

[Emily McMinn :emcminn]

I think it would be dependent on bug 1811069, which is quite a bit more complex so I wasn't sure we'd want to uplift them both, esp. since the RTAMO population is relatively small. If we think the impact is going to be significant, I can request both uplifts :)

Comment 15

[Shane Caraveo (:mixedpuppy)]

RTAMO has been on an uptick in numbers so far this year and is running around 10K users per week. These users, who have just installed Firefox, will encounter a panel that appears to require installation of the addon. This could result in a negative impression for those new users. If the necessary patches apply cleanly, or with little effort, I'd like uplift to be considered. Do you know whether the patches will apply to beta?

Comment 16

[Punam Dahiya [:pdahiya]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #15)

RTAMO has been on an uptick in numbers so far this year and is running around 10K users per week. These users, who have just installed Firefox, will encounter a panel that appears to require installation of the addon. This could result in a negative impression for those new users. If the necessary patches apply cleanly, or with little effort, I'd like uplift to be considered. Do you know whether the patches will apply to beta?

probably safer to do a beta only patch that fixes RTAMO without pre-MR onboarding cleanup and request uplift, @emcminn wdyt?

Comment 17

[Shane Hughes [:aminomancer]]

The patch for bug 1811069 is very impractical to graft onto beta IMO. I actually think it would be more sensible to write a patch just for Fx111 without all the cleanup from bug 1811069, solely to fix the button position issue. Trying to avoid all the inevitable conflicts of this massive cleanup patch just to fix the position of a button isn't worth it, and I think it's not all that unusual to do a beta specific patch.

Very much agree with Punam, didn't notice your response! We are definitely on the same page haha

Comment 18

[Emily McMinn :emcminn]

^ I agree! I figured bug 1811069 was too complex for uplift which is why I initially marked this as wontfix. I didn't realize RTAMO was having such an impact, which is pretty cool - I can take a look at writing a beta patch tomorrow :)

Comment 19

[Shane Hughes [:aminomancer]]

Sounds great, please r? me too, I would really like to see how the process for a beta patch works.

Comment 20

[Alex Cornestean]

Hello,

Verified as Fixed on the latest Nightly (112.0a1/20230228085339).

The page is no longer cut at the bottom and the “Not Now” button is fully visible. The blue progress bar has also been removed.

Functionality of the button is not affected.

See the attached screenshots for more details. Note that one of the screenshots depicts Release and Nightly side by side for comparison.

Comment 21

[Alex Cornestean]

Attachment: 2023-03-01_09h58_37.png

Comment 22

[Alex Cornestean]

Attachment: 2023-03-01_09h58_57.png

Comment 23

[Emily McMinn :emcminn]

Attachment: Bug 1818437 - Beta patch to address RTAMO screen design being cut

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 25

[Emily McMinn :emcminn]

Comment on attachment 9320623 [details]
Bug 1818437 - Beta patch to address RTAMO screen design being cut

Beta/Release Uplift Approval Request

• User impact if declined: Users landing on the RTAMO page during onboarding will see a panel with the "not now" button appearing cut off/hidden; the panel may appear to require installation of the addon. This could result in a negative impression for those new users.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On windows, open the newtab devtools:
  In about:config, set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true and open via the wrench icon on newtab.

Open the targeting tab in the left-hand menu, scroll to the bottom and click the blue "Force Attribution" button.

about:welcome should now show the RTAMO screen; a full blue progress bar should be visible at the bottom of the content, and the "Not Now" button should be fully visible.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch reverts the changes from https://phabricator.services.mozilla.com/D166833 for Beta only; no other patches should be affected
• String changes made/needed: none
• Is Android affected?: No

Comment 26

[Donal Meehan [:dmeehan]]

Comment on attachment 9320623 [details]
Bug 1818437 - Beta patch to address RTAMO screen design being cut

Approved for 111.0b8

Comment 27

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/852524c5c611

Comment 28

[Alex Cornestean]

Verified as Fixed on the latest Beta (111.0b8/20230302185836).

The RTAMO about:welcome page content is no longer cut at the bottom, the “Not Now” button being fully visible. A full blue progress bar is also present at the bottom of the content.

Functionality is not affected.

For more details, see the attached screenshot.

Comment 29

[Alex Cornestean]

Attachment: 2023-03-03_09h36_22.png