1818516 - Refactor shell command line option processing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jon Coppeard (:jonco)]

Right now processing of shell command line options happen inline in several functions. Options are not grouped by area but are all mixed together. This would benefit from some more organisation.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 1: Move processing of pre-init shell global options to a separate function r?nbp

Code motion only. Moves processing of options that are set prior to calling
JS_Init to their own function. (I don't know whether all of these actually
require calling before init.)

Depends on D170769

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 2: Move processing of post-init shell global options to a separate function r?nbp

Same as previous patch, for options that are set post-init but before creating a context.

Depends on D170770

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 3: Move SetContextOptions to the end of the source file r?nbp

This moves the existing SetContextOptions to the end of the file with the other
option processing functions before adding to it in later patches.

Depends on D170771

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 4: Split out Wasm options in to their own function r?nbp

Depends on D170772

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 5: Split JIT options out into their own function r?nbp

Depends on D170774

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 6: Split GC options out into their own function r?nbp

Depends on D170775

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 8: Move other GC option processing into SetContextGCOptions r?nbp

Where possible, move setup of other GC options in to the new function.

Depends on D170776

Comment 8

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 9: Move other Wasm option processing into SetContextWasmOptions r?nbp

Depends on D170777

Comment 9

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 10: Move other parser option processing into SetContextOptions r?nbp

Depends on D170778

Comment 10

[Jon Coppeard (:jonco)]

Attachment: Bug 1818516 - Part 0: Move shell options setup into a separate function r?nbp

Code motion only. This factors out a function to initialize the OptionParser.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d6e8c2b8797
Part 0: Move shell options setup into a separate function r=nbp
https://hg.mozilla.org/integration/autoland/rev/9af7213c6005
Part 1: Move processing of pre-init shell global options to a separate function r=nbp
https://hg.mozilla.org/integration/autoland/rev/3884c0168cd8
Part 2: Move processing of post-init shell global options to a separate function r=nbp
https://hg.mozilla.org/integration/autoland/rev/993bef6e6474
Part 3: Move SetContextOptions to the end of the source file r=nbp
https://hg.mozilla.org/integration/autoland/rev/67d103bb6aec
Part 4: Split out Wasm options in to their own function r=nbp
https://hg.mozilla.org/integration/autoland/rev/5860f4e22343
Part 5: Split JIT options out into their own function r=nbp
https://hg.mozilla.org/integration/autoland/rev/10e1b40bac21
Part 6: Split GC options out into their own function r=nbp
https://hg.mozilla.org/integration/autoland/rev/5776938a5bfd
Part 8: Move other GC option processing into SetContextGCOptions r=nbp
https://hg.mozilla.org/integration/autoland/rev/5dd69ed2e447
Part 9: Move other Wasm option processing into SetContextWasmOptions r=nbp
https://hg.mozilla.org/integration/autoland/rev/fad377f07bd6
Part 10: Move other parser option processing into SetContextOptions r=nbp

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9d6e8c2b8797
https://hg.mozilla.org/mozilla-central/rev/9af7213c6005
https://hg.mozilla.org/mozilla-central/rev/3884c0168cd8
https://hg.mozilla.org/mozilla-central/rev/993bef6e6474
https://hg.mozilla.org/mozilla-central/rev/67d103bb6aec
https://hg.mozilla.org/mozilla-central/rev/5860f4e22343
https://hg.mozilla.org/mozilla-central/rev/10e1b40bac21
https://hg.mozilla.org/mozilla-central/rev/5776938a5bfd
https://hg.mozilla.org/mozilla-central/rev/5dd69ed2e447
https://hg.mozilla.org/mozilla-central/rev/fad377f07bd6