1818536 - Clearing data in PBM should not clear regular data

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Split out from comment 3 in bug 1818267.

Right now we cannot clear site data while in private browsing mode. If the user tries to disable CBH in a private window, we call the SiteDataManager to clear data, which doesn't clear private browsing data, but instead clears the user's regular browsing mode data. This seems likely to surprise and confuse users, especially as we clear data from the base domain (eTLD + 1).

The right fix here is to only attempt to clear data if we're in a regular browsing window.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1818536 - Do not clear regular site data when disabling cookie banner handling in private mode. r?pbz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c4ffe291d1d
Do not clear regular site data when disabling cookie banner handling in private mode. r=pbz

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1c4ffe291d1d