Closed Bug 1818598 Opened 1 year ago Closed 1 year ago

Nested image-set funcs should fail to parse

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: canadahonk, Assigned: canadahonk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

image-set() should not be parsed correctly when nested.

Example invalid value: image-set(image-set(url(example.png)) 2x)

WPT tests (2 currently fail): https://github.com/web-platform-tests/wpt/blob/a2154e3f971f3630643741206ce02bbbc5f31d6f/css/css-images/image-set/image-set-parsing.html#L223-L239

Spec quote (from https://www.w3.org/TR/css-images-4/#image-set-notation):

The image-set() function can not be nested inside of itself, either directly or indirectly (as an argument to another <image> type).

Assignee: nobody → oj
Attachment #9319581 - Attachment description: Bug 1818598 - Fix parsing nested image-set funcs correctly → Bug 1818598 - Fix parsing nested image-set funcs as valid
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a154633506f0
Fix parsing nested image-set funcs as valid r=layout-reviewers,emilio

Looks like previous internal tests were incorrect (?), didn't catch those. Need adjusting, will do. Apologies.

Flags: needinfo?(oj)

Fixed.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad709052e86e
Fix parsing nested image-set funcs as valid r=layout-reviewers,emilio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: