1818604 - Layout Debugger often triggers "LoadURI must have a triggering principal" when loading local file

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Emily McDonough [:alaskanemily]]

This seems to only happen with local files, and sometimes does not happen after loading the file in the main browser first.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Would be good to know where this regressed, or a stack? At a glance we always pass a triggering principal: https://searchfox.org/mozilla-central/rev/f7edb0b474a1a922f3285107620e802c6e19914d/layout/tools/layout-debug/ui/content/layoutdebug.js#485-492

I couldn't repro this fwiw, either by running ./mach run -layoutdebug /path/to/file.html, nor pasting the file URI directly on the URL bar...

Comment 2

[Emily McDonough [:alaskanemily]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Would be good to know where this regressed, or a stack? At a glance we always pass a triggering principal: https://searchfox.org/mozilla-central/rev/f7edb0b474a1a922f3285107620e802c6e19914d/layout/tools/layout-debug/ui/content/layoutdebug.js#485-492

I couldn't repro this fwiw, either by running ./mach run -layoutdebug /path/to/file.html, nor pasting the file URI directly on the URL bar...

I think I figured something out: It only happens when using the "open file" dialog in the layout debugger. Pasting in a URL works.

Comment 3

[Daniel Bodea [:danibodea]]

would you please provide the exact steps to reproduce? If I can constantly reproduce it, I'll attempt to provide a regression range.
Also, which operating system are you using and which exact version reproduced the issue in your case?
Thank you for your contribution!

Comment 4

[Emily McDonough [:alaskanemily]]

Just to reiterate, it only occurs if you use the "open file" dialog (as in, control + O and choose a file). Entering a URL into the address bar or passing it on the command line doesn't cause any problems.

I managed to narrow it down to the range of bd736c46b91b49eafad19d00a67f98a8bf529361 to 1fe10fe2909d06436587af06dd9b0f5ecf31e14a so it looks like this started with bug 1810141

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bd736c46b91b49eafad19d00a67f98a8bf529361&tochange=1fe10fe2909d06436587af06dd9b0f5ecf31e14a

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1810141

:Gijs, since you are the author of the regressor, bug 1810141, could you take a look?

For more information, please visit auto_nag documentation.

Comment 6

[:Gijs (he/him)]

Aside: Wow, the layout debugger's process switching is... not very sophisticated and crashes a lot, aside from this issue. :-(

(e.g.: load a https URI, then load a local file, then hit the back button)

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1818604 - unbreak loading files using 'open file' in the layout debugger, r?emilio

Comment 8

[:Gijs (he/him)]

Anyway, sorry for breaking this without realizing. :-(

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba81b338492a
unbreak loading files using 'open file' in the layout debugger, r=emilio

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ba81b338492a

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[:Gijs (he/him)]

We're in RC week so uplifting to release doesn't seem reasonable at this point.