1818652 - Build error with non-unified disable-jemalloc mozconfig: "nsTraceRefcnt.cpp:549:7: error: use of undeclared identifier 'base'"

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Build with this mozconfig:

ac_add_options --disable-unified-build
ac_add_options --disable-jemalloc

(Optional shortcut: interrupt the build partway through and run ./mach build xpcom/base to jump directly to the relevant part.)

ACTUAL RESULTS:
This build error:

nsTraceRefcnt.cpp:549:7: error: use of undeclared identifier 'base'
       base::RegisterForkServerNoCloseFD(fileno(stream));
       ^

EXPECTED RESULTS:
No such build error.

To provide that API, we need to include base/process_util.h. nsTraceRefcnt.cpp already has an include for that, but it's ifdeffed behind MOZ_DMD. Presumably that ifdef-guard isn't enabled when jemalloc is disabled, I guess.

We can fix this by just pulling the include out of the ifdef guard.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1818652: Unguard an include in nsTraceRefcnt.cpp, to address a non-unified-build compile error. r?mccr8

Also move the include to the top of the list, to its proper sorted-include-list
location, and insert a blank line after the .cpp file's own .h file, to match
common convention in mozilla code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b6339639566
Unguard an include in nsTraceRefcnt.cpp, to address a non-unified-build compile error. r=mccr8

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0b6339639566