1818965 - Update PDF.js to new version 2da2ac492ef3fdba4bc9f6fb992bda2fb57dbb82 from 2023-02-26 12:22:23

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 6 commits.. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/content/build/pdf.js | 30 ++++++--------
toolkit/components/pdfjs/content/build/pdf.scripting.js | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.js | 23 +++++++----
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 10 +++++
toolkit/components/pdfjs/content/web/viewer-geckoview.js | 6 +-
toolkit/components/pdfjs/content/web/viewer.css | 10 +++++
toolkit/components/pdfjs/content/web/viewer.js | 6 +-
toolkit/components/pdfjs/moz.yaml | 4 +-
8 files changed, 58 insertions(+), 35 deletions(-)

---

580180a720546855698424f293a152f4b96c1773 by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/580180a720546855698424f293a152f4b96c1773
Authored: 2023-02-26 13:15:43 +0100
Committed: 2023-02-26 13:15:43 +0100

Bump versions in pdfjs.config

Files Modified:

• pdfjs.config

---

5075d0495b422b8f0245bb10dad355899672d8d7 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/5075d0495b422b8f0245bb10dad355899672d8d7
Authored: 2023-02-24 11:29:58 +0100
Committed: 2023-02-24 11:29:58 +0100

Use OffscreenCanvas as intended for all code-paths in src/display/text_layer.js (PR 15722 follow-up)

Currently some getCtx calls will have isOffscreenCanvasSupported === undefined set, meaning that OffscreenCanvas isn't being used as intended, since no TextLayerRenderTask._isOffscreenCanvasSupported property exists.

Please note: This patch is written using the GitHub UI, since I'm currently without a dev machine, so hopefully it works correctly.

Files Modified:

• src/display/text_layer.js

---

3a2142338614b3ff507932b1bee41f327b6fdc8c by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/3a2142338614b3ff507932b1bee41f327b6fdc8c
Authored: 2023-02-22 22:08:21 +0100
Committed: 2023-02-23 12:09:39 +0100

[Acroform] Use the full path to find the node in the XFA datasets where to store the value

I noticed several 'Path not found' errors because of a field called #subform[2].
From the XFA specs, the hash is used for a class of elements in the template tree.
When we're looking for a node in the datasets tree, it doesn't make sense to search
for a class. Hence the path element starting with a hash are just skipped.

Files Added:

• test/pdfs/f1040_2022.pdf.link
• test/pdfs/issue16081.pdf.link

Files Modified:

• src/core/annotation.js
• src/core/worker.js
• src/core/writer.js
• src/display/api.js
• test/test_manifest.json
• test/unit/api_spec.js

---

a074525bfbfc5ba7a225be27068de5c88692f780 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/a074525bfbfc5ba7a225be27068de5c88692f780
Authored: 2023-02-22 12:01:56 +0100
Committed: 2023-02-22 19:39:28 +0100

[a11y] Improve the visibility of link annotations in HCM

In order to help to identify a link, we add a border around it with the LinkText color.
And backdrop colors are inverted when the mouse pointer hovers them, this way it should
help to identify the link where the pointer is.

Files Modified:

• web/annotation_layer_builder.css

---

1b076b7a359e10c8b2fd38cdf00f088767ad12ba by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/1b076b7a359e10c8b2fd38cdf00f088767ad12ba
Authored: 2023-02-21 12:00:45 +0100
Committed: 2023-02-21 12:00:45 +0100

Move the ImageBitmap clean-up into the PDFObjects class

With upcoming changes we'll potentially start to cache ImageBitmap data at the document-level, in addition to just at the page-level.
Hence we need to ensure that such data is actually released on clean-up, and rather than duplicating the existing manual handling this code is instead moved into the PDFObjects.clear method. (In my opinion, this is an overall improvement even without globally cached ImageBitmap data.)

Please note: This patch is written using the GitHub UI, since I'm currently without a dev machine, so hopefully it's correct and makes sense.

Files Modified:

• src/display/api.js

---

dca54c8f8a34e1ac63b6a746fbf09fac6df34df5 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/dca54c8f8a34e1ac63b6a746fbf09fac6df34df5
Authored: 2023-02-19 16:33:05 +0100
Committed: 2023-02-19 16:33:05 +0100

[JS] Send a Validate action on change on Choice widget

Files Added:

• test/pdfs/issue16067.pdf

Files Modified:

• src/display/annotation_layer.js
• test/integration/scripting_spec.js
• test/pdfs/.gitignore

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=fa160ea9be037b9d7bede70b0736626b7e943bd5

Comment 2

[Update Bot]

Attachment: Bug 1818965 - Update PDF.js to 2da2ac492ef3fdba4bc9f6fb992bda2fb57dbb82

Comment 3

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (From Push Health):

• No tests were found for flavor 'plain' and the following manifest filters:
  skip_if, run_if, fail_if, subsuite(name=None), tags(['condprof']), pathprefix(['toolkit/components/pdfjs/test'])

  Make sure the test paths (if any) are spelt correctly and the corresponding
  --flavor and --subsuite are being used. See mach mochitest --help for a
  list of valid flavors.

  • 3 of 3 failed on different tasks
    - test-linux1804-64-qr/opt-mochitest-plain-condprof-1 (dLWpCl3vQGq5oYx9MocLIw)
    - test-windows11-64-2009-qr/opt-mochitest-plain-condprof-1 (ACtPS-TlQG6BROL3BCsVug)
    - test-windows10-64-2004-qr/opt-mochitest-plain-condprof-1 (UCdCCY7mSRqO40NtR9W_Xw)

Needs Investigation (Other Failed Jobs):

• test-linux1804-64-qr/debug-mochitest-devtools-chrome-1
  • 4 of 4 failed on the same (retriggered) task (HeuION5uRuqgNXYZ4sBzcg, HVwNe6SXQ2W8Kz3xzOwwEA, KP0FgBAuT2KBO-lfDCA6VA, N49zYGC7RMylSLSWb_9png)
• test-linux1804-64-qr/debug-mochitest-devtools-chrome-spi-nw-1
  • 4 of 4 failed on the same (retriggered) task (FMvIgKvUTiClvV7kCPHS6Q, IYexqLHLT9OIcRVxXeduIg, MOvLspFnSU-XMDAojdTvhw, YsebhW6WTXCgnnCunS7VWw)
• test-windows11-64-2009-qr/debug-mochitest-devtools-chrome-spi-nw-1
  • 4 of 4 failed on the same (retriggered) task (RuR691-NRh6loPiElAmK4g, Ldpz9ARyQ2SBn6HY7j80RQ, Vel8VMFMQ6mCJlKWUfAnMA, B1rLTpXLTsWhzh7cjD2zhA)
• test-windows10-64-2004-qr/debug-mochitest-devtools-chrome-1
  • 4 of 4 failed on the same (retriggered) task (WEnLgCwxQQKi5cEtp4SckA, Rst4UxPZR2KNnqRSoROEiw, WIHihnxMT4mRpm2Tqnu8tg, ZrdSpl3TSMmxdQa4sw0YZQ)
• test-windows11-64-2009-qr/debug-mochitest-devtools-chrome-1
  • 4 of 4 failed on the same (retriggered) task (INkQ0gNqSJSd33bPxHuj4g, T8jOsOhpRueupU-ZzWAAug, HCFwTKWNRSGs7Lx9WdiMGQ, B1J850swTWyjt6DPhZw9Uw)
• test-macosx1015-64-qr/debug-mochitest-devtools-chrome-1
  • 4 of 4 failed on the same (retriggered) task (JsoHMkMnRVaIO4klJLFB1w, MkC6u07EQlO9VHRYX-vcoA, LbEGz2X0TYiqoTg0MYDFrA, VM03RgKbQiGUyBJ3kMPRoA)
• test-windows10-64-2004-qr/debug-mochitest-devtools-chrome-spi-nw-1
  • 4 of 4 failed on the same (retriggered) task (KbnOmpgJSrC3dSgtWWo3fA, L7B6J5cAQ1CF3eOrFhVWwg, YKmrB6TfQ3CfpHf-SNaSkw, LkVOeLqrTVmQT8-gbW7G5Q)
• test-macosx1015-64-qr/debug-mochitest-devtools-chrome-spi-nw-1
  • 4 of 4 failed on the same (retriggered) task (c_XHe8IBTC6dl5jSkRfW9A, QkQNAKdGTxmf0g40pZ22xQ, cvonl9XMSkePHqnHOJouqw, eXiuuFfYTgyoxIXQiZ3jgQ)
• test-linux1804-64-qr/debug-mochitest-devtools-chrome-swr-1
  • 4 of 4 failed on the same (retriggered) task (RlNb5RYQTbivdazUEFFJrQ, daVD7ya0QfyfIETIXDljMg, ZBZFtpdWQZ6QRcwmg2Iwew, COqtiAXLTXuqCe_8qgAiGg)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7a8883b7af5
Update PDF.js to 2da2ac492ef3fdba4bc9f6fb992bda2fb57dbb82 r=calixte

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f7a8883b7af5