181898 - When selecting into quoted text in mail compose, then typing, letters go into mail quote

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Simon Fraser [no longer active]]

To repro:
1. Set mail account prefs to use plaintext mail compose
2. Set mail prefs to quote the original message on reply
4. Reply to mail (I used a plaintext mail)
5. Select from the end of the text to the beginning of a line of quoted text,
   or, select from the start of a line of quoted text (at the left margin) to
   the end of the text.
6. Type a few characters.

Notice how the typed characters are in the quoted text (they are colored, and if
you continue to type, the line does not wrap).

Expected result: typing puts the letters in non-quoted text.

Workaround: hit return before starting to type.

Comment 1

[Joe Francis]

From the end of what text?  I can't tell from this report where yor selection
is.  Are both ends inside the quote?  If not, had you typed some text outside
the quote first?

Comment 2

[Joe Francis]

trying to repro this on tip (I think, not sure about directions) I see that if
seelction starts outside quote and ends in quote, we get unquoted text.  If
selection starts in quote and ends anywhere (inside or outside quote) we get
quoted text.

I could add a check for deletions that places you outside the mailquote whenever
any part of the deletion is outside.  Right now you end up either inside or
outside the quote depending on:
1) which endpoint was in the quote
2) whether you hit backspace or forward-delete (where typing or doing something
that implicitly deletes selection counts as backspace)

These rules are intentional and work well for other html structure, but I guess
we should special case mailquotes, since people expect to end up outside them if
at all possible.

Comment 3

[Simon Fraser [no longer active]]

To be explicit, in a virgin, plain-text reply to an email, drag-select backwards
from outside the text (below it), to the start of a line inside the quoted text.
I.e. given this:

> foo
> bar
> baz

start selecting after the baz (in the space below that line), and select
backwards to before the > on the '> bar' line. Then hit a characters, as if you
were typing to replace the selection.

Comment 4

[Joe Francis]

note to self: fix 161969 when fixing this.

Comment 5

[Joe Francis]

fix landed on trunk