1819012 - Crash in [@ java.lang.NullPointerException: at org.mozilla.focus.fragment.BrowserFragment.onAccessibilityStateChanged(BrowserFragment.kt:40)]

Status: RESOLVED FIXED

(Focus :: General, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/5b746ee5-b059-41f2-9066-e04700230227

I suspect this crash was a regression in Focus 107. The earliest crash reports are from Focus 107.1.0.

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.focus.fragment.BrowserFragment.onAccessibilityStateChanged(BrowserFragment.kt:40)
	at android.view.accessibility.AccessibilityManager.lambda$-android_view_accessibility_AccessibilityManager_36305(AccessibilityManager.java:1007)
	at android.view.accessibility.-$Lambda$T3m_l9_RA18vCOcakSWp1lZCy5g$1.$m$0(Unknown Source:6)
	at android.view.accessibility.-$Lambda$T3m_l9_RA18vCOcakSWp1lZCy5g$1.run(Unknown Source:0)
	at android.os.Handler.handleCallback(Handler.java:808)
	at android.os.Handler.dispatchMessage(Handler.java:101)
	at android.os.Looper.loop(Looper.java:166)
	at android.app.ActivityThread.main(ActivityThread.java:7396)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:926)

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1819012 - Change browser toolbar behavior only if view is created. (#1006)

Comment 2

[Chris Peterson [:cpeterson]]

If the fix is safe, we should consider uplifting this Focus crash fix to Beta and maybe even a dot release.

Comment 3

[Chris Peterson [:cpeterson]]

No need to uplift to 110, but we should consider for a 111 dot release.

Comment 4

[Chris Peterson [:cpeterson]]

Petru, do you think this Focus crash fix would be a good uplift for a 111.0.1 dot release next week? Or should it wait for another week of testing in Beta 112?

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Yes, this is a straightforward patch that comes to bring on Focus the same null check we were already doing in Fenix.
Haven't look much into the issue but would agree that it's a recent one, from when Focus got the dynamic toolbar.
Mihai to confirm and work out the backport patch.

Comment 6

[Mihai Adrian Carare [:mcarare]]

I can confirm the change is minor, the only change consists in using a nullable variable instead of a non-null one, in order to be able to null check, instead of throwing an NPE.

Comment 7

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1819012 - Change browser toolbar behavior only if view is created. (backport #1006) (#1238)

Comment 8

[Mihai Adrian Carare [:mcarare]]

Comment on attachment 9323031 [details] [review]
[mozilla-mobile/firefox-android] Bug 1819012 - Change browser toolbar behavior only if view is created. (backport #1006) (#1238)

Beta/Release Uplift Approval Request

• User impact if declined: In some cases, the app can crash if the change in the a11y services state occurs before the browser fragment view is created.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Reproducing this requires specific timing that is not easily controlled: activating the a11y services at the exact moment that the view is not created, but navigation to the browser fragment has already occurred.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The only relevant change is code is replacing a non-null variable with a nullable variable and a null check.
• String changes made/needed: None.
• Is Android affected?: Yes

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9323031 [details] [review]
[mozilla-mobile/firefox-android] Bug 1819012 - Change browser toolbar behavior only if view is created. (backport #1006) (#1238)

Approved for Android Focus 111.1.0

Comment 10

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/6aa0d6cceebef81b2e19be7841de83764c3acc56
[releases_v111] Bug 1819012 - Update browser toolbar behavior only if view is created.