If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Docshell ignores nsIWebNavigation::loadURI headers arg

RESOLVED FIXED

Status

()

Core
Document Navigation
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Adam Lock, Assigned: Adam Lock)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

5.86 KB, patch
Brian Ryner (not reading)
: review+
rpotts (gone)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
Docshell ignores the headers parameter, making the postdata parameter pretty
useless. Patch follows.
(Assignee)

Updated

15 years ago
Blocks: 100629
(Assignee)

Comment 1

15 years ago
Created attachment 107382 [details] [diff] [review]
Patch

Patch adds 'headersStream' attribute to nsIDocshellLoadInfo and code to use it.
I've also detabbed and cleaned up the idl a bit since it was a mess.

Rick, can you sr this?
(Assignee)

Comment 2

15 years ago
Comment on attachment 107382 [details] [diff] [review]
Patch

Can I have an r/sr on this straightforward patch to add a headerStream
attribute to nsIDocShellTreeInfo?
Attachment #107382 - Flags: superreview?(rpotts)
Attachment #107382 - Flags: review?(bryner)
Comment on attachment 107382 [details] [diff] [review]
Patch

It might just be diff weirdness, but it looks like the indentation of the
comments in nsIDocShellLoadInfo.idl is a little off.  Make sure that's good anr
r=bryner.
Attachment #107382 - Flags: review?(bryner) → review+

Comment 4

15 years ago
Comment on attachment 107382 [details] [diff] [review]
Patch

looks good to me.

-- rick
Attachment #107382 - Flags: superreview?(rpotts) → superreview+
(Assignee)

Comment 5

15 years ago
Fix is checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.