1819079 - PiP's disabled subtitle button remains visible in View Mode while full screen (does not hide)

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: issue

Notes

• When subtitles are enabled from the main player, the icon becomes active and this issue does not reproduce.

Found in

• Nightly 112.0a1

Affected versions

• Nightly 112.0a1
• Firefox 111.0b6

Tested platforms

• macOS 12
• Windows 10
• Ubuntu 22

Affected platforms

• macOS 12
• Windows 10
• Ubuntu 22

Preconditions

• media.videocontrols.picture-in-picture.improved-video-controls.enabled set to true

Steps to reproduce

1. Launch Firefox.
2. Go to https://youtube.com and select a video.
3. Enable PiP and make it fullscreen.
4. Wait a little until the controls fade.

Expected result

• All PiP controls disappear if the user does not interact with the PiP window after is set to fullscreen.

Actual result

• The subtitles icon is still shown.

Regression range

• Unlikely to be a regression, the behavior has been present since the new layout has been implemented.

Comment 1

[kpatenio]

I can only reproduce with videos that don't support cc (example). The PiP subtitles button will remain disabled in this case, and the button in its disabled state does not hide as it should in full screen mode. We may need to modify how we hide the disabled button in player.css, to take into account that the showing attribute can be removed despite hovering over a full screen video.

Comment 2

[kpatenio]

Attachment: Bug 1819079 - hide PiP cc button on hover only if PiP window is not full screen

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db659519ca30
hide PiP cc button on hover only if PiP window is not full screen r=pip-reviewers,bnasar,niklas

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/db659519ca30

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Daniel Bodea [:danibodea]]

This fix has been verified in the latest Nightly v113.0a1 on Windows 10, Ubuntu 22 and MacOS11.