1819081 - Add Bookmark telemetry

Status: RESOLVED FIXED

(Firefox :: Firefox View, task)

Description

[Sarah Clements [:sclements]]

We need to add probes for the bookmarks sidebar and bookmarks library window

• cumulative searches before an item is clicked (include single click from context menu and opening multiple links)
• total number of bookmarks opened per session (include multiple items opened per middle mouse click or context menu)

See Leif's inventory doc ("surface key/screenshots "tab) for clarity on each of these surfaces: https://docs.google.com/spreadsheets/d/1Q4_vfTSmv0nysbFLe88VJSiUrRjI0rnO1UFTRRK1OBA/edit#gid=2111169208

Comment 1

[Sarah Clements [:sclements]]

Attachment: Firefox Data Collection Request - Telemetry for Bookmarks use in Library and Sidebar

Comment 2

[Sarah Clements [:sclements]]

Attachment: Bug 1819081 - Add telemetry to bookmarks sidebar and library r=mak,kcochrane

• Add histograms for cumulative searches and utilize scalars added in bug 1815906
• Add test coverage

Comment 3

[Chris H-C :chutten]

Comment on attachment 9323051 [details]
Firefox Data Collection Request - Telemetry for Bookmarks use in Library and Sidebar

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :sclements is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/811fbfb31174
Add telemetry to bookmarks sidebar and library r=mak

Comment 5

[Marian-Vasile Laza]

Backed out changeset 811fbfb31174 (Bug 1819081) for bc failures on browser_views_liveupdate.js.
Backout link
Push with failures <--> bc2
Failure Log

Comment 6

[Sarah Clements [:sclements]]

(In reply to Marian-Vasile Laza from comment #5)

Backed out changeset 811fbfb31174 (Bug 1819081) for bc failures on browser_views_liveupdate.js.
Backout link
Push with failures <--> bc2
Failure Log

Hi, I'm really perplexed by this failure. When I look at my try push before this landed on autoland yesterday the bc1 tests were passing (and today, I rebased on mc and did another try push where I see the failure). https://treeherder.mozilla.org/jobs?repo=try&author=sclements%40mozilla.com&searchStr=bc1

But I can't reproduce this locally. I think something else is causing these failures but I haven't been able to pinpoint which patch.

Additionally, when I look at the changes I made on my patch between last thursday and yesterday, the only changes I made were to the browser_sidebar_bookmarks_telemetry.js: https://phabricator.services.mozilla.com/D172596?vs=693827&id=694840#toc

Marian, have you seen the failures to browser_views_liveupdate.js happen in other patches since mine was backed out from autoland? I really would like to land my patch and get it uplifted to beta.

Comment 7

[Sarah Clements [:sclements]]

I figured out the issue with the test and current try push is green, so re-landing it.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d1e601af7b8
Add telemetry to bookmarks sidebar and library r=mak

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2d1e601af7b8

Comment 10

[Sarah Clements [:sclements]]

Comment on attachment 9323054 [details]
Bug 1819081 - Add telemetry to bookmarks sidebar and library r=mak,kcochrane

Beta/Release Uplift Approval Request

• User impact if declined: This builds on previous work to expand bookmarks and history telemetry. If this request is delayed, it will cause a delay in data that product needs to determine feature work currently being planned.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch adds new probes and makes small code changes to capture user interactions with bookmarks in the library and sidebar. Automated tests were added to ensure this works as expected. This builds on work added in bug 1817251.
• String changes made/needed: No
• Is Android affected?: No

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9323054 [details]
Bug 1819081 - Add telemetry to bookmarks sidebar and library r=mak,kcochrane

Approved for 112.0b6

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/89e31ab04363