181909 - some regression tests for Error invalid

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Jörg Schaible]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; Q312461)
Build Identifier: Rhino 1.5 release 4 0000 00 00 (in progress)

The regression tests js/tests/ecma_3/Exceptions/15.11.4.4-1.js and 
js/tests/ecma_3/Exceptions/regress-181654.js fail to test the meggase argument. 
The validating comparison just checks for the content of Error.message in 
Error.toString without checking whether the given message of the constructor is 
contained in the message.

Reproducible: Always

Steps to Reproduce:

Actual Results:  
js/tests/ecma_3/Exceptions/regress-181654.js has a bug, that results in a 
missing/empty Error.message member, but the test succeeds.

Expected Results:  
The test should have failed.

two patches will be attached.

Comment 1

[Jörg Schaible]

Attachment: js\tests\ecma_3\Exceptions\15.11.4.4-1.js.patch

Comment 2

[Jörg Schaible]

Attachment: js\tests\ecma_3\Exceptions\regress-181654.js.patch

Comment 3

[Jörg Schaible]

Attachment: js\tests\ecma_3\Exceptions\regress-181654.js.patch

Corrected another (copy & paste) bug in regression test.

Comment 4

[Phil Schwartau]

Assigning to self -

Comment 5

[Phil Schwartau]

Marking FIXED.

Jörg: thank you for your precise observations on this!
I've checked in your fixes to both tests -

Comment 6

[Phil Schwartau]

Marking Verified -

Comment 7

[Igor Bukanov]

Targeting as resolved against 1.5R4