1819166 - Add a toolchain for Visual Studio 2022 (for running performance testing on chromium builds)

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Description

[Kash Shampur [:kshampur] ⌚EST]

I'm trying to get Chromium builds going in CI for Windows, for some of our performance testing comparisons.

According to the latest instructions, VS 2022 is required
https://chromium.googlesource.com/chromium/src/+/main/docs/windows_build_instructions.md#setting-up-windows

in particular, it also mentions that these additional components are required

Microsoft.VisualStudio.Workload.NativeDesktop
Microsoft.VisualStudio.Component.VC.ATLMFC

(and for ARM 64 these as well)

Microsoft.VisualStudio.Workload.NativeDesktop
Microsoft.VisualStudio.Component.VC.ATLMFC
Microsoft.VisualStudio.Component.VC.Tools.ARM64
Microsoft.VisualStudio.Component.VC.MFC.ARM64

and whatever is included in the --includeRecommended flag

I am not 100% sure, but I think I would require a vs2022.yaml, similar to the 2019 one? e.g. https://searchfox.org/mozilla-central/source/build/vs/vs2019.yaml

Additionally it seems the Windows SDK version 10.0.22621 is required.

Would it be possible to generate a

• similar yaml file
• have the SDK (& debugger?) available in CI? (unsure if this should be a separate task altogether, but the docs say This can be installed separately or by checking the appropriate box in the Visual Studio Installer. suggests to me it could potentially be part of the yaml?)

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

Attachment: vs2022.yaml

I've made an attempt here.

I got these warnings when creating the attached yaml (are these ok?):

kshampur@MacBook-Pro-10 mozilla-unified % ./mach python --virtualenv build build/vs/generate_yaml.py \
  --major \
  17 \
  Microsoft.VisualStudio.Workload.NativeDesktop \
  Microsoft.VisualCpp.CRT.Headers \
  Microsoft.VisualCpp.CRT.Redist.ARM64 \
  Microsoft.VisualCpp.CRT.Redist.X64 \
  Microsoft.VisualCpp.CRT.Redist.X86 \
  Microsoft.VisualCpp.CRT.x64.Desktop \
  Microsoft.VisualCpp.CRT.x64.Store \
  Microsoft.VisualCpp.CRT.x86.Desktop \
  Microsoft.VisualCpp.CRT.x86.Store \
  Microsoft.VisualCpp.DIA.SDK \
  Microsoft.VisualCpp.Tools.HostX64.TargetARM64 \
  Microsoft.VisualCpp.Tools.HostX64.TargetX64 \
  Microsoft.VisualCpp.Tools.HostX64.TargetX86 \
  Microsoft.VisualStudio.Component.VC.ATL.ARM64 \
  Microsoft.VisualStudio.Component.VC.ATLMFC \
  Microsoft.VisualStudio.Component.VC.MFC.ARM64 \
  Win11SDK_10.0.22621 \
  -o \
  build/vs/vs2022.yaml
Fetching https://aka.ms/vs/17/release/channel
Got toplevel manifest for 17.5.1
Loaded installer manifest for 17.5.1
WARNING: Microsoft.VisualStudio.VC.Ide.ATL_-2066987101 not found
WARNING: Microsoft.VisualStudio.VC.Ide.ATL_-2066987101 not found
WARNING: Microsoft.VisualStudio.VC.Ide.WinXPlus_-845988912 not found
WARNING: Microsoft.VisualStudio.Devenv_-997348683 not found
WARNING: Microsoft.VisualStudio.NuGet.Core_2105225524 not found
WARNING: Microsoft.DataAI.NuGetRecommender_2105225524 not found
WARNING: Microsoft.VisualStudio.NuGet.BuildTools_1230994547 not found
WARNING: Microsoft.VisualCpp.Tools.Common.Utils_-2066987101 not found
WARNING: Microsoft.VisualCpp.Tools.Common.Utils.Resources_-2066987101 not found
WARNING: Microsoft.VisualCpp.Tools.Common.UtilsPrereq_-2066987101 not found
WARNING: Microsoft.VisualStudio.Devenv.Msi_-2066987101 not found
WARNING: Microsoft.VisualStudio.Diagnostics.AspNetHelper.Enterprise_1779377902 not found
WARNING: Microsoft.VisualStudio.Diagnostics.AspNetHelper.Standard_-289185459 not found
WARNING: Microsoft.VisualStudio.Enterprise_1779377902 not found
WARNING: Microsoft.VisualStudio.Professional_341893570 not found
WARNING: Microsoft.VisualStudio.Debugger.TimeTravel.Replay.Plat.17_1779377902 not found
WARNING: Microsoft.VisualStudio.Debugger.TimeTravel.Replay.VS.17_1779377902 not found
WARNING: Microsoft.VisualStudio.SccCodeLenses_341893570 not found
WARNING: Microsoft.PythonTools.BuildCore.Vsix_1230994547 not found
WARNING: Microsoft.VisualStudio.VC.Ide.Progression.Enterprise_1779377902 not found
WARNING: Microsoft.VisualStudio.PackageGroup.TestTools.DataCollectors_-1097644363 not found
WARNING: Microsoft.VisualStudio.PackageGroup.TestTools.CodeCoverage_-1097644363 not found
WARNING: Microsoft.VisualStudio.PackageGroup.TestTools.TestPlatform.Legacy_-1097644363 not found
WARNING: Microsoft.VisualStudio.PackageGroup.TestTools.TestPlatform.V1.CLI_-1097644363 not found
WARNING: Microsoft.VisualStudio.TestTools.Pex.Common_-1097644363 not found
WARNING: Microsoft.VisualStudio.TestTools.CodeCoverage_1779377902 not found
WARNING: Microsoft.VisualStudio.TestTools.CodeCoverage.Msi_1779377902 not found
WARNING: Microsoft.VisualStudio.TestTools.DynamicCodeCoverage_1779377902 not found
WARNING: Microsoft.VisualStudio.PackageGroup.IntelliTrace.Core_1779377902 not found
WARNING: Microsoft.VisualStudio.Component.VC.CoreIDE_-845988912 not found
WARNING: Microsoft.VisualStudio.Component.VC.Tools.x86.x64_-845988912 not found
WARNING: Microsoft.VisualStudio.Component.VC.CoreIDE_-845988912 not found
WARNING: Microsoft.VisualStudio.Component.VC.Tools.x86.x64_-845988912 not found
WARNING: Microsoft.VisualStudio.VC.CMake.Project_-2066987101 not found
WARNING: Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions.CMake_-2066987101 not found
WARNING: Microsoft.VisualStudio.PackageGroup.VC.CoreIDE.Reduced_-2066987101 not found
WARNING: Microsoft.VisualStudio.Component.JavaScript.TypeScript_-2066987101 not found
WARNING: Microsoft.VisualStudio.Component.Roslyn.LanguageServices_-2066987101 not found
WARNING: Microsoft.VisualStudio.Component.Debugger.JustInTime_-2066987101 not found
WARNING: Microsoft.VisualStudio.Component.IntelliTrace.FrontEnd_1779377902 not found
WARNING: Microsoft.VisualStudio.VC.Ide.MFC_-2066987101 not found
WARNING: Microsoft.VisualStudio.VC.Ide.MFC_-2066987101 not found

attempted toolchain Try job

Unsure what to make of the errors at the moment...

Attempted to revendor vsdownload.py but there have not been any significant changes as you can see from this Try

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

hi :glandium :)

I saw that you worked on the vs2019.yml version of this, would you be able to help with this?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Kash Shampur [:kshampur] ⌚EST from comment #0)

Microsoft.VisualStudio.Workload.NativeDesktop

This is what's causing problems, and I doubt you actually need it. Maybe a few of its direct or indirect dependencies, but certainly not the whole thing.

Comment 4

[Kash Shampur [:kshampur] ⌚EST]

Thanks for the suggestion, that did seem to work.

I think I will close this for now, despite the instructions page suggesting vs 2022, I dug into some files and it seems that vs2019 and even vs2017 may technically still be supported, so I will continue on with the existing toolchain

Comment 5

[Kash Shampur [:kshampur] ⌚EST]

Re opening as I ended up needing this after all for Bug 1818363. I will submit a patch in the coming days

Comment 6

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1819166 - Add a toolchain for Visual Studio 2022. r?#build

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11dca7a0a089
Add a toolchain for Visual Studio 2022. r=firefox-build-system-reviewers,glandium

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/11dca7a0a089