1819195 - Attachment bar should be dark with dark theme - macOS

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB Attachement bar with dark theme.jpeg

Steps to reproduce:

1. Set dark theme on macOS version without system dark theme (in my case 10.13.6)
2. Select a received message with an attachment

Actual results:

The attachment bar is white

Expected results:

Attachment bar should be dark with dark theme.

It was okay on TB102 & TB110b4

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1819195 - Use variables for the attachment bar colors. r=#thunderbird-front-end-reviewers

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1819195 - Use white in thread pane for unread messages with dark themes. r=aleca

Comment 3

[Phabricator Automation]

Comment on attachment 9320572 [details]
Bug 1819195 - Use white in thread pane for unread messages with dark themes. r=aleca

Revision D171353 was moved to bug 1819544. Setting attachment 9320572 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e34a4e58b0f
Use variables for the attachment bar colors. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9320477 [details]
Bug 1819195 - Use variables for the attachment bar colors. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
User impact if declined: attachment tool bar has wrong colour on old macOS versions
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9320477 [details]
Bug 1819195 - Use variables for the attachment bar colors. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/ec88d2afe2bd