1819211 - Minor clean up for Baseline.h

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See the upcoming patch for the detail.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1819211 - Export Baseline.h under mozilla.

It is because Baseline is a utility class under namespace mozilla.

Also change the include guard to match the coding style.
https://firefox-source-docs.mozilla.org/code-quality/coding-style/coding_style_cpp.html#header-files

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1819211 - Revise documentation in Baseline.h.

The documentation for these functions might be missed when these functions was
moved from nsIFrame.h to Baseline.h in
https://hg.mozilla.org/mozilla-central/rev/fbf495c37e23.

I also revise the documentation because the old ones might be wrong. Here are
some corrections.

1. An alphabetical "first"/"last" baseline should be at the "end"/"start" edge
   of a margin/border/content-box.
2. SynthesizeBOffsetFromBorderBox() works when aFrame's writing-mode is
   orthogonal to aWM, but the other two functions are not.

Depends on D171162

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d214e7da664e
Export Baseline.h under mozilla. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c8925446ab89
Revise documentation in Baseline.h. r=emilio

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d214e7da664e
https://hg.mozilla.org/mozilla-central/rev/c8925446ab89