Closed Bug 1819214 Opened 2 years ago Closed 2 years ago

QuickFilter Dropdown selectbox not themed with Dark theme - macOS (without system dark theme)

Categories

(Thunderbird :: Theme, defect)

Thunderbird 112
Unspecified
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
112 Branch

People

(Reporter: NicolasWeb, Assigned: micah)

References

(Blocks 1 open bug)

Details

(Keywords: ux-consistency, Whiteboard: [Supernova3p])

Attachments

(2 files)

Steps to reproduce:

  1. Set dark theme on macOS version without system dark theme (in my case 10.13.6)
  2. Click Tag button on the Quick filters toolbar

Actual results:

Dropdown selectbox is the system one, not themed, white

Expected results:

All the quick filter UI should respect the dark theme.

It was okay on TB102 & TB110b4

Keywords: ux-consistency
Whiteboard: [Supernova]
Summary: TB QuickFilter Dropdown selectbox not themed with Dark theme - macOS (without system dark theme) → QuickFilter Dropdown selectbox not themed with Dark theme - macOS (without system dark theme)

Thanks for the report.
This issue is not strictly related to the dark/light theme, but the fact that that element is an HTML select and it shouldn't be.

Micah, can you take care of this.
That element should be a xul:menulist like this.

Assignee: nobody → micah
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(micah)
Flags: needinfo?(micah)
Status: NEW → ASSIGNED
Target Milestone: --- → 112 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/641daf9ac6a8
Convert QuickFilter Dropdown select to XUL menulist. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: [Supernova] → [Supernova3p]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: