1819309 - Some RSS feed items are coloured black when selected instead of blue

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[WIlliam Davis [:AwesomeSheep48]]

Attachment: Black RSS feed slection

In a few of my RSS folders, all of the messages – when selected – are coloured black instead of blue. This happens to all of the messages in the affected folder, but not all the folders in the same account.

Comment 1

[WIlliam Davis [:AwesomeSheep48]]

Attachment: Blue RSS feed slection

Comment 2

[Richard Marti (:Paenglab)]

Do you have "Automatically create tags from feed <category> names" enabled? You can find this in Subscribe... of the folder's context menu.

Comment 3

[WIlliam Davis [:AwesomeSheep48]]

Yes, that is enabled in the folders which have this issue

Comment 4

[Magnus Melin [:mkmelin]]

Assuming it's the color of that tag then, and the items affected have got the tag?

Comment 5

[Richard Marti (:Paenglab)]

William, can you give me the Feed address with the auto tagging? The feeds I have don't make the tags.

Comment 6

[WIlliam Davis [:AwesomeSheep48]]

(In reply to Richard Marti (:Paenglab) from comment #5)

William, can you give me the Feed address with the auto tagging? The feeds I have don't make the tags.

Here are a few which do this https://rss.cbc.ca/lineup/canada.xml, https://rss.cbc.ca/lineup/politics.xml, https://www.chch.com/category/news/feed/

Comment 7

[WIlliam Davis [:AwesomeSheep48]]

(In reply to Magnus Melin [:mkmelin] from comment #4)

Assuming it's the color of that tag then, and the items affected have got the tag?

I looked in settings just now, and yes, all the tags are set to be black; though I cannot remember it being like this until around a week ago, I still had "Automatically create tags from feed <category> names" enabled, but there was no colour change.

Comment 8

[Richard Marti (:Paenglab)]

Geoff, this RSS autotags are a bit special. They don't have a colour set which ends in a empty --tag-color. This then makes TB use black as colour but the --tag-contrast-color is also set to black. Is it possible to give the --tag-color a colour (or maybe currentColor) when no colour is set?

You can test it also by removing a colour of an existing tag in prefs.js

Comment 9

[Geoff Lankow (:darktrojan)]

If we just don't add a rule for tags with no colour, the problem should go away, right? It works when I change the tag preferences.

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1819309 - Don't create CSS rules for tags with no colour. r=Paenglab

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9c3f6d8cb341
Don't create CSS rules for tags with no colour. r=Paenglab

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9320724 [details]
Bug 1819309 - Don't create CSS rules for tags with no colour. r=Paenglab

[Triage Comment]
Approved for beta

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/f18dbcd85abd