Closed Bug 1819328 Opened 1 year ago Closed 1 year ago

Message filters window should flex - Not all UI is visible at the bottom

Categories

(Thunderbird :: Filters, defect)

Thunderbird 112
Unspecified
All
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird110 unaffected, thunderbird111 affected, thunderbird112 fixed, thunderbird113 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird110 --- unaffected
thunderbird111 --- affected
thunderbird112 --- fixed
thunderbird113 --- fixed

People

(Reporter: NicolasWeb, Assigned: mkmelin)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [snnot3p])

Attachments

(2 files, 2 obsolete files)

Steps to reproduce:

  1. Open Message Filters window
  2. Add many filters so the filters list need to scroll
  3. Resize the Message Filters window
  4. Update TB recursively for days

Actual results:

  1. Step 1 : the bottom of the Message filters list is cut by the window border
  2. Step 3: the window do not adapt to not scroll
  3. Able to resize (higher especially) the windows to show all and even a huge blank space at the bottom
  4. After some restarts & updates, the Message Filters window take back it initial wrong size

Expected results:

  1. Message filter list should not be cut
  2. Message Filters window should adapt to window size

This was working well on TB 102 & TB 110b4

OS: Unspecified → macOS
Attached image TB Message filters higher.jpeg (obsolete) —

Maybe from flexbox emulation changes.

Keywords: regression
See Also: → 1819479
Whiteboard: [snnot]

(In reply to Magnus Melin [:mkmelin] from comment #2)

Maybe from flexbox emulation changes.

Meanwhile bug 1821304 is fixed, I mark it as depend on , so easier to track if it's a Dupeme

Blocks: 1821304
No longer depends on: 1821304
Assignee: nobody → mkmelin+mozilla

Also fix some issues with resizing sideways when changing account.

Depends on D172366

So for the vertical scrollbar, you need to set min-height: 0 to this box and this box to allow the richlistbox to shrink effectively. But the first box is completely redundant afaict and you can just remove it.

For the horizontal scrollbar you need min-width: 0 on those same boxes. You probably also want crop="end" on the <label> so that the text is ellipsized instead of just overflowing.

Does that help?

Flags: needinfo?(mkmelin+mozilla)

The window is larger, by default, but too much compared to the content of the colums.
Is it possible to make it (more) adaptative to the colums' content ?

If the Filters names could be ellipsized when too long, that would be perfect ! :)

That's what I have with the current patch : https://bugzilla.mozilla.org/attachment.cgi?id=9323111

Is it possible to make it (more) adaptative to the colums' content ?

There are other elements that need the space, so can't shrink the name column.
Yes, the filter names will now get ellipsis if too long.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

Does that help?

Yes indeed, thanks for the pointers!!

Flags: needinfo?(mkmelin+mozilla)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: macOS → All
Target Milestone: --- → 113 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d1e7ed2ffeed
Message filters list wasn't getting scrollbar. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Duplicate of this bug: 1823133
Duplicate of this bug: 1823408

Since bug 1822418 is still not fixed, the appearance of the not hidden filter make the bottom controls to overlap the window bottom border.
Deleting that automatic filter, give the window the right size.
Resizing the windows to a smaller size do not make the Filters list to high adaptable / flexing => that hide bottom controls totally

Not sure where is the best to report that, as this filter should not appear in the UI.

TB 113.0a1 build 20230322101319

Attachment #9320273 - Attachment is obsolete: true
Attachment #9320277 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

For any further bugs under special conditions, please file a new bug with steps to reproduce.

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED

Comment on attachment 9322581 [details]
Bug 1819328 - Message filters list wasn't getting scrollbar. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta (pre-req bug 1824507)

Attachment #9322581 - Flags: approval-comm-beta+
Blocks: 1824507

(In reply to Magnus Melin [:mkmelin] from comment #14)

For any further bugs under special conditions, please file a new bug with steps to reproduce.

Thank you Magnus. Since bug 1824507, the issue of comment #13 has gone, so no new bug to report :)

Whiteboard: [snnot] → [snnot3p]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: