Message filters window should flex - Not all UI is visible at the bottom
Categories
(Thunderbird :: Filters, defect)
Tracking
(thunderbird_esr102 unaffected, thunderbird110 unaffected, thunderbird111 affected, thunderbird112 fixed, thunderbird113 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | --- | unaffected |
thunderbird110 | --- | unaffected |
thunderbird111 | --- | affected |
thunderbird112 | --- | fixed |
thunderbird113 | --- | fixed |
People
(Reporter: NicolasWeb, Assigned: mkmelin)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [snnot3p])
Attachments
(2 files, 2 obsolete files)
48 bytes,
text/x-phabricator-request
|
rjl
:
approval-comm-beta+
|
Details | Review |
172.31 KB,
image/jpeg
|
Details |
Steps to reproduce:
- Open Message Filters window
- Add many filters so the filters list need to scroll
- Resize the Message Filters window
- Update TB recursively for days
Actual results:
- Step 1 : the bottom of the Message filters list is cut by the window border
- Step 3: the window do not adapt to not scroll
- Able to resize (higher especially) the windows to show all and even a huge blank space at the bottom
- After some restarts & updates, the Message Filters window take back it initial wrong size
Expected results:
- Message filter list should not be cut
- Message Filters window should adapt to window size
This was working well on TB 102 & TB 110b4
Reporter | ||
Updated•1 year ago
|
Reporter | ||
Comment 1•1 year ago
|
||
Assignee | ||
Comment 2•1 year ago
|
||
Maybe from flexbox emulation changes.
Updated•1 year ago
|
Reporter | ||
Comment 3•1 year ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #2)
Maybe from flexbox emulation changes.
Meanwhile bug 1821304 is fixed, I mark it as depend on
, so easier to track if it's a Dupeme
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 4•1 year ago
|
||
Also fix some issues with resizing sideways when changing account.
Depends on D172366
Comment 5•1 year ago
|
||
Comment 6•1 year ago
|
||
For the horizontal scrollbar you need min-width: 0
on those same boxes. You probably also want crop="end"
on the <label>
so that the text is ellipsized instead of just overflowing.
Does that help?
Reporter | ||
Comment 7•1 year ago
•
|
||
The window is larger, by default, but too much compared to the content of the colums.
Is it possible to make it (more) adaptative to the colums' content ?
If the Filters names could be ellipsized when too long, that would be perfect ! :)
That's what I have with the current patch : https://bugzilla.mozilla.org/attachment.cgi?id=9323111
Assignee | ||
Comment 8•1 year ago
|
||
Is it possible to make it (more) adaptative to the colums' content ?
There are other elements that need the space, so can't shrink the name column.
Yes, the filter names will now get ellipsis if too long.
Assignee | ||
Comment 9•1 year ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)
Does that help?
Yes indeed, thanks for the pointers!!
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Comment 10•1 year ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d1e7ed2ffeed
Message filters list wasn't getting scrollbar. r=aleca
Reporter | ||
Comment 13•1 year ago
|
||
Since bug 1822418 is still not fixed, the appearance of the not hidden filter make the bottom controls to overlap the window bottom border.
Deleting that automatic filter, give the window the right size.
Resizing the windows to a smaller size do not make the Filters list to high adaptable / flexing => that hide bottom controls totally
Not sure where is the best to report that, as this filter should not appear in the UI.
TB 113.0a1 build 20230322101319
Reporter | ||
Updated•1 year ago
|
Reporter | ||
Updated•1 year ago
|
Assignee | ||
Comment 14•1 year ago
|
||
For any further bugs under special conditions, please file a new bug with steps to reproduce.
Comment 15•1 year ago
|
||
Comment on attachment 9322581 [details]
Bug 1819328 - Message filters list wasn't getting scrollbar. r=#thunderbird-front-end-reviewers
[Triage Comment]
Approved for beta (pre-req bug 1824507)
Comment 16•1 year ago
|
||
bugherder uplift |
Thunderbird 112.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/e20f04420b45
Reporter | ||
Comment 17•1 year ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #14)
For any further bugs under special conditions, please file a new bug with steps to reproduce.
Thank you Magnus. Since bug 1824507, the issue of comment #13 has gone, so no new bug to report :)
Updated•11 months ago
|
Description
•