1819366 - Trying to bookmark a page doesn't allow me to hit "Save".

Status: RESOLVED INCOMPLETE

(Firefox :: Bookmarks & History, defect)

Description

[ronagon]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

I hit "Control + D" and also the star symbol in the far right end of the URL window, and the "Save" button on the far bottom right was not engageable so that I could click on it.

Actual results:

I think it may have bookmarked/saved anyways, without my needing to click on it, but it's not supposed to work that way -- it's unsettling and inconsiderate

Expected results:

It should only bookmark/save the page if the "Save" button is in fact clicked, and the button seems to never be usable anymore.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak]]

(In reply to ronagon from comment #0)

I hit "Control + D" and also the star symbol in the far right end of the URL window, and the "Save" button on the far bottom right was not engageable so that I could click on it.

What does "not engageable" mean? Can you provide a screenshot?
Which Linux distribution and window manager are you using? This bug may be related to that.

I think it may have bookmarked/saved anyways, without my needing to click on it, but it's not supposed to work that way

This panel works with a Save-by-default behavior, that's a design choice.
Note however you can click again on the star (or ctrl+D again) to reopen the panel and click on Remove Bookmark (If you didn't click on Cancel originally), there's no downside in doing that.

For other bookmark dialogs, we are testing a behavioral change in Nightly where you'll effectively have to Accept for changes to be saved. The only exception will continue being the Add Bookmark star panel and the Library details panel.

Comment 3

[ronagon]

Marco,

I mean the “Save” button is not colored blue like it always has been before, as an in inductor that it will register when clicked on. And accordingly, it does not register when clicked on it is colored black and stays black when clicked on. In other words, the button no longer works, whereas it always has before, for the well-over-a-decade that I’ve been using Firefox.

Also, I am in no way a stranger to the use of the Bookmark feature of Firefox, and it has never jus automatically saved the bookmark as you are claiming it normally does — only in the very most recent updates has it started acting this way, now making the “Save” button apparently superfluous. And if that is going to be its new standard functioning, then the “Save” button should probably now just be removed entirely, as it is now just vestigial.

Finally, I use Firefox on both Windows 10 and Ubuntu (Debian) systems, and it’s been doing this on both systems.

Comment 4

[Mark Banner (:standard8)]

Do you have a userChrome.css file in your profiles? If so, that could be causing this type of issue.

We have not recent changed the functionality of the dialog, and have had no other reports of it misbehaving. Maybe you accidentally unchecked "Show editor when saving"?

Comment 5

[Simona Badau, Desktop QA]

Ronagon,
When time permits, could you please answer the questions from Comment 4? Thanks!

Comment 6

[Simona Badau, Desktop QA]

Closing as Resolved: Incomplete due to no update from the reporter. If anyone can still reproduce this issue, please feel free to reopen the bug. Thanks!