Closed
Bug 1819372
Opened 1 year ago
Closed 1 year ago
Use moz-button-group in ETP panel
Categories
(Toolkit :: UI Widgets, task)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: mstriemer, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(3 files, 1 obsolete file)
The cookie banner reduction section ETP panel has a pair of buttons to change the setting. These should be wrapped in a moz-button-group so that they are ordered correctly. Ensure that the tab order is correct on Windows, particularly.
It's possible that there may need to be an update to moz-button-group to move the light DOM button, since the panel handles the tab key itself. Also check for any existing order: -1 rules that may need updates (likely this one [1])
|
||
Updated•1 year ago
|
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D173891
|
|
||
Updated•1 year ago
|
Attachment #9325554 -
Attachment is obsolete: true
|
|
||
Updated•1 year ago
|
Attachment #9325555 -
Attachment description: WIP: Bug 1819372 - Part 1: Reorder light DOM in moz-button-group r?hjones,tgiles → Bug 1819372 - Part 1: Reorder light DOM in moz-button-group r?hjones,tgiles
|
|
||
Updated•1 year ago
|
Attachment #9325556 -
Attachment description: WIP: Bug 1819372 - Part 2: Use moz-button-group in Cookie Banner Reduction panel r?jhirsch,dwalker → Bug 1819372 - Part 2: Use moz-button-group in Cookie Banner Reduction panel r?jhirsch,dwalker
|
|
Assignee | |
Comment 4•1 year ago
|
||
Depends on D173892
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39b61e65abfe Part 1: Reorder light DOM in moz-button-group r=hjones https://hg.mozilla.org/integration/autoland/rev/faff8ddbf66b Part 2: Use moz-button-group in Cookie Banner Reduction panel r=pbz https://hg.mozilla.org/integration/autoland/rev/1983ea2af562 Part 3: Use moz-button-group in ETP report site panel r=pbz
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/39b61e65abfe
https://hg.mozilla.org/mozilla-central/rev/faff8ddbf66b
https://hg.mozilla.org/mozilla-central/rev/1983ea2af562
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
|
||
Updated•2 months ago
|
Whiteboard: [fidefe-reusable-components] → [recomp]
You need to log in
before you can comment on or make changes to this bug.
Description
•