1819392 - some links in about: dialog do not work

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Rob Lemley [:rjl]]

The "unsupported" and "manual download" links do not work in the About dialog. There is no "href" attribute on the <a> elements.

Comment 1

[Magnus Melin [:mkmelin]]

Should be filled by https://searchfox.org/comm-central/rev/39e2f40bf7dd57bc8c9279875025d1250c874601/mail/base/content/aboutDialog-appUpdater.js#62-64,164 (if MOZ_UPDATER - https://searchfox.org/comm-central/rev/39e2f40bf7dd57bc8c9279875025d1250c874601/mail/base/content/aboutDialog.js#13)

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1819392 - Fix links in about:dialog. r=#thunderbird-front-end-reviewers

The manualLink class needs to be on links that set by a preference value such
as "manual download" and "unsupported version". "download-link" was causing a
conflict and setting two event handlers on those links. Add preventDefault() to
the event handlers to prevent the about dialog itself from displaying the linked
content.

Comment 3

[Rob Lemley [:rjl]]

There appears to be a conflict with https://searchfox.org/comm-central/rev/ffca7da7ce1f80465e21cafb0b950e5d96626305/mail/base/content/aboutDialog-appUpdater.js#304-311

I can't quite get rid of aboutDialog-appUpdater.js#304-311 because the updater portion of Settings->General still uses that code.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d019eadc036
Fix links in about:dialog. r=aleca