Move Bookmarks Toolbar items only when command key held

VERIFIED WONTFIX

Status

defect
VERIFIED WONTFIX
17 years ago
14 years ago

People

(Reporter: stf, Assigned: mikepinkerton)

Tracking

unspecified
Future
PowerPC
macOS

Details

(Reporter)

Description

17 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021125 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021125 Chimera/0.6+

The existing Bookmarks Toolbar items can be rearranged/moved/dragged without
holding down the Command key, the insertion line is appearing. The Toolbar (with
Location field) and all OS X toolbars can only be rearranged by holding down the
CMD key.

Reproducible: Always

Steps to Reproduce:


Actual Results:  
Existing items are draggable inside the Bookmarks Toolbar without holding the
command key.

Expected Results:  
Allow to rearranged them only if CMD key is holded down.

Comment 1

17 years ago
-->sfraser
Assignee: brade → sfraser

Comment 2

17 years ago
If that's how Toolbars generally work on OS X (and it appears they do), then the
Bookmarks Toolbar should probably behave the same way for consistency's sake.

Then again, those other toolbars usually have customization dialogs as well,
which Bookmarks Toolbar doesn't. Is the BT a different type of toolbar that can
obey different rules?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Bookmarks Toolbar items moved with Cmd-drag only → Move Bookmarks Toolbar items only when command key held
> Is the BT a different type of toolbar that can obey different rules?
Yes. It's not a toolbar like the main toolbar is (Cocoa only allows you one of
those). It's just a view with a bunch of buttons that we lay out ourselves.
Status: NEW → ASSIGNED

Comment 4

17 years ago
If you're going to make it more like a toolbar, it would be nice to make it a
real toolbar. I wonder if there's some way to hack that in? Normally a cocoa
window only wants to have one toolbar. The window doesn't really need to know
about the bookmarks bar though. It might be possible to make an NSView subclass
that owns an NSToolbar .. assuming there's no hidden API magic .. you'd also get
the "identifier" synchronization for free.

Comment 5

16 years ago
This would be very a great idea. Making it a real toolbar would solve tons f
other issues we have with the one we have now.
It can't be a real toolbar; those can only live at the top of the window.
->pink
Assignee: sfraser → pinkerton
Status: ASSIGNED → NEW
i don't think we want this (no other browser does it), but keeping alive for
discussion.
Target Milestone: --- → Future
Bump. I suggest WONTFIX.

No other browsers do this, nor does it make too much sense other than to prevent
a user from accidentally removing bookmarks. It's not expected behavior though.
I don't think we should do this, either. We added a threshold for starting the
drag a while ago, so it's a lot harder to accidentally drag the bookmarks now.
That's really the only functional reason I can see for doing this.
Agreed WONTFIX
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.