1819558 - Optimize constructor calls to bound functions in CacheIR

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

The new implementation that landed in bug 1483869 doesn't optimize this yet. Constructor calls are not common in Speedometer for example, but this might regress other workloads and this cliff is relatively easy to fix.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1819558 part 1 - Support bound constructors in tryAttachCallHook. r?iain!

We have to guard on the bound function's is-constructor flag, but other than that
it's the same as invoking other construct hooks.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1819558 part 2 - Refactor scripted call code to allow sharing more of it. r?iain!

This factors out emitCallScriptedGuards and CanOptimizeScriptedCall helper functions
that bound-scripted and unbound-scripted calls can share. Also adds a newTarget
argument to getThisShapeForScripted to prepare for the next patch.

Depends on D171329

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1819558 part 3 - Optimize bound-scripted constructor calls. r?iain!

Depends on D171330

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2db84bed24d6
part 1 - Support bound constructors in tryAttachCallHook. r=iain
https://hg.mozilla.org/integration/autoland/rev/260ee9be2402
part 2 - Refactor scripted call code to allow sharing more of it. r=iain
https://hg.mozilla.org/integration/autoland/rev/f04c5bdd5599
part 3 - Optimize bound-scripted constructor calls. r=iain

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2db84bed24d6
https://hg.mozilla.org/mozilla-central/rev/260ee9be2402
https://hg.mozilla.org/mozilla-central/rev/f04c5bdd5599