1819604 - Message header panels like More button menu or Remote Content Preferences menu should have dark background with dark theme - macOS

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB More button Header should be black with dark theme on old macOS.jpeg

Steps to reproduce:

1. Set dark theme on macOS version without system dark theme (in my case 10.13.6)
2. Click on the More button on Message reader
3. Click on Customize

Actual results:

It's all themed light

Expected results:

Dark theme should apply here too

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1819604 - Use white in thread pane for unread messages with dark themes. r=aleca

Comment 2

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB remonte content menu.jpeg

I just found that the same issue apply to the remote content warning bar button menu.

Richard, is your patch fixing this too please ? (or I report another bug)

Comment 3

[Phabricator Automation]

Comment on attachment 9320550 [details]
Bug 1819604 - Use white in thread pane for unread messages with dark themes. r=aleca

Revision D171353 was moved to bug 1819195. Setting attachment 9320550 [details] to obsolete.

Comment 4

[Richard Marti (:Paenglab)]

Sorry, the patch wasn't for this bug.

The issue affects all panels. I'll create tomorrow a patch.

Comment 5

[Thomas D. (:thomas8)]

Thanks for letting us know, Nicolas!

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug 1819604 - Use layout variables for panels and menupopups inside the messageBrowser. r=aleca

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/66405ac2b380
Use layout variables for panels and menupopups inside the messageBrowser. r=aleca

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9320773 [details]
Bug 1819604 - Use layout variables for panels and menupopups inside the messageBrowser. r=aleca

[Approval Request Comment]
Regression caused by (bug #): [Supernova]
User impact if declined: popups in message header don't get the correct coloures on older macOS versions
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9320773 [details]
Bug 1819604 - Use layout variables for panels and menupopups inside the messageBrowser. r=aleca

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/fc004a09ff36