Closed Bug 1819635 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38769 - [wip] Serialize variable-referencing properties as original text.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38769 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38769
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

[wip] Serialize variable-referencing properties as original text.

This uses more PartitionAlloc RAM (as much as 720 kB on the Video subtest),
but is more consistent with how custom properties are serialized.
We hope to gain some of that back later, by no longer storing the parsed
tokens. It also costs us a little in increased memory allocation costs
during parsing.

Parse (µs) Before After Perf 95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce 1374 1384 -0.8% [ -1.7%, +0.3%]
Encyclopedia 7304 7341 -0.5% [ -0.9%, -0.2%]
Extension 1349 1362 -1.0% [ -2.2%, +0.1%]
News 8036 8116 -1.0% [ -1.4%, -0.6%]
Search 4999 5045 -0.9% [ -1.3%, -0.5%]
Social1 15309 15444 -0.9% [ -1.2%, -0.5%]
Social2 615 628 -2.1% [ -2.9%, -1.4%]
Sports 55919 56479 -1.0% [ -1.3%, -0.7%]
Video 36887 37470 -1.6% [ -1.9%, -1.3%]
Geometric mean -1.1% [ -1.5%, -0.7%]

Change-Id: I86d8f3b3d754974af2459de480a0ea7cc2107975

Reviewed-on: https://chromium-review.googlesource.com/4294946
WPT-Export-Revision: 8b453d23e2ea1a1025c2902ac3571c44506560f8

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d4fd2d9ddfe [wpt PR 38769] - Serialize variable-referencing properties as original text., a=testonly https://hg.mozilla.org/integration/autoland/rev/16b45a8f30dd [wpt PR 38769] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/8d4fd2d9ddfe
https://hg.mozilla.org/mozilla-central/rev/16b45a8f30dd

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.