1819736 - Make test-manifest-alpha more helpful and actionable in its comments

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Mike Conley (:mconley) (:⚙️)]

test-manifest-alpha currently complains when mochitest ini files are out of order, which is great. It even goes so far as to provide the expected ordering. Fantastic!

What it doesn't do, however, is give you guidance on how to reorder the prior state of the ini file to become alphabetical. This is normally trivial in short ini files, but in sufficiently long ones, it'd be helpful if test-manifest-alpha gave some assistance.

Using difflib, I think we can do this.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1819736 - Make test-manifest-alpha more helpful in its feedback. r?ahal!

This patch makes it so that test-manifest-alpha emits a diff between unsorted
and sorted order to make it easier for people to reorder these files (since it's
currently kinda difficult to reorder the files automatically).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d848dbfa71cc
Make test-manifest-alpha more helpful in its feedback. r=ahal

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d848dbfa71cc