1819737 - Add Extension Crash listener in GV to determine when we should restart the extension background pages

Status: RESOLVED FIXED

(GeckoView :: Extensions, task, P2)

Description

[Zac McKenney [:zmckenney]]

When the Extension Process crashes, the crash report should check the auto-restart limit and restart the process if necessary

Comment 1

[Zac McKenney [:zmckenney]]

After talking with other teams, we will want to have an extension crash listener that can determine which background pages to load. When the background pages are recreated/reloaded, the process will be restarted.

Comment 2

[William Durand [:willdurand]]

Attachment: WIP: Bug 1819737 - Listen to the `ExtensionProcessCrashObserver` "crash" event and propagate it to the embedder using a delegate. r?rpl!,zmckenney

This patch adds some (partial) logic to propagate the "extension-process-crash"
event to the embedders. We send a request with a response, which is then used
to determine what to do in gecko, i.e. whether we want to keep recreating the
process or not.

Comment 3

[Zac McKenney [:zmckenney]]

Attachment: Bug 1819737 - Listen for extension process crashes and pass to new delegate methods r=willdurand

Comment 4

[William Durand [:willdurand]]

Attachment: Bug 1819737 - Add deferred task and counter to monitor extensions process crashes. r?rpl!

Depends on D184071

Comment 5

[William Durand [:willdurand]]

Attachment: WIP: Bug 1819737 - Listen for extension process crashes and pass to new delegate methods.

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1819737 - Extension process restart (#3152)

Comment 8

[William Durand [:willdurand]]

The patch that will close this bug adds the necessary GV bits so that when a crash happens, GV is notified. When too many crashes have occurred and Gecko disabled the extensions process spawning, GV will emit an event to the embedder (so that the app can show some UI to the user). In addition, the embedder will be able to enable the process spawning again with a new method on the WebExtension controller.

Bug 1848426 is where the Gecko logic will be added.

Comment 9

[Phabricator Automation]

Comment on attachment 9346652 [details]
Bug 1819737 - Add deferred task and counter to monitor extensions process crashes. r?rpl!

Revision D185030 was moved to bug 1848426. Setting attachment 9346652 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43d2261c5611
Listen for extension process crashes and pass to new delegate methods r=geckoview-reviewers,willdurand,owlish,amejiamarmol

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/43d2261c5611

Comment 12

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1819737 - Added extensions process crash handling (#3459)

Comment 13

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/5dfa25932930a94dcf062b3868ba3f692af65c96
[main] Bug 1819737 - Added extensions process crash handling

Comment 14

[William Durand [:willdurand]]

:mixedpuppy as per the uplift request process guide (which explains why I need your approval ;-)), I'd like to nominate the PR attached to this bug as a candidate to backport to the 118 branch given that the patch in GV landed in Fx118 already. Are you OK with that? Thanks!

Comment 15

[Shane Caraveo (:mixedpuppy)]

I approve.

(In reply to William Durand [:willdurand] from comment #14)

:mixedpuppy as per the uplift request process guide (which explains why I need your approval ;-)), I'd like to nominate the PR attached to this bug as a candidate to backport to the 118 branch given that the patch in GV landed in Fx118 already. Are you OK with that? Thanks!

Comment 16

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1819737 - Added extensions process crash handling (backport #3459) (#3491)

Comment 17

[William Durand [:willdurand]]

Comment on attachment 9351466 [details] [review]
[mozilla-mobile/firefox-android] Bug 1819737 - Added extensions process crash handling (backport #3459) (#3491)

Beta/Release Uplift Approval Request

• User impact if declined: None.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk because it is covered by tests and the patch in itself doesn't do much. It is however a requirement for us to be able to enable the extensions process in Fx118 (via Nimbus) because that patch will enable some UI for end-users.

Note that only the Fenix patch (Pull Request) needs to be uplifted, the other patch (in GeckoView) made it to the 118 branch.

• String changes made/needed:
• Is Android affected?: Yes

Comment 18

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9351466 [details] [review]
[mozilla-mobile/firefox-android] Bug 1819737 - Added extensions process crash handling (backport #3459) (#3491)

Approved for 118.0b5, thanks.

Comment 19

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/7cdf3ba65a030ce759fc69ab5c5d3b0b13f8488e
[releases_v118] Bug 1819737 - Added extensions process crash handling

Authored by https://github.com/pascalchevrel
https://github.com/mozilla-mobile/firefox-android/commit/1749836c16a42def748baced88f8ea030e0af0ca
[releases_v118] Merge pull request #3491 from mozilla-mobile/mergify/bp/releases_v118/pr-3459