1819760 - Dragging and dropping the identity box to the desktop to create a .url shortcut is broken (creates .url.download instead of .url)

Status: VERIFIED FIXED

(Firefox :: File Handling, defect, P1)

Description

[Frank]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0

Steps to reproduce:

Mouse right click on the padlock symbol and release the mouse button on the Windows Explorer file area.

Actual results:

Firefox 112.0a1 Build-ID 20230301093735:
A shortcut file was created, but instead of type ".url" now as "url.download".
Windows can't work with the type ".download".

Expected results:

Create a shortcut file of type ".url" like in the version before.
Windows can open the shortcut in Firefox Nightly (my standard browser) again.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::File Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

This is the result of a security fix that impacted downloads (maybe bug 1809923, maybe one of the related bugs), but where clearly our attempt to be generic and prevent this everywhere led to us breaking expected functionality. :-(

Comment 3

[Neil Deakin]

We should be able to fix this by modifying CreateURLFilenameFromTextA/CreateURLFilenameFromTextW to pass the VALIDATE_ALLOW_INVALID_FILENAMES flag.

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a429f4ea7c488a624126534dd88637cb0c475cfb&tochange=bce007ba1a3fdb155321a15a3430395dddbccb4a

Comment 5

[Neil Deakin]

Attachment: Bug 1819760, don't modify extensions when trying to create a desktop shortcut, r=gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/731c660cee74
don't modify extensions when trying to create a desktop shortcut, r=Gijs

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/731c660cee74

Comment 8

[Frank]

YES! Thank you all, it works again!

Comment 9

[:Gijs (he/him)]

(In reply to Frank from comment #8)

YES! Thank you all, it works again!

Thanks for the quick update and for reporting this so quickly after it broke; it helped avoid shipping this regression to the release channel. :-)

Comment 10

[Neil Deakin]

Attachment: WIP: Bug 1819760, don't modify extensions when trying to create a desktop shortcut, esr version

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 12

[Neil Deakin]

Comment on attachment 9326152 [details]
WIP: Bug 1819760, don't modify extensions when trying to create a desktop shortcut, esr version

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Regression from bug 1815062 which is needed if that bug is landed.
• User impact if declined: Dragging a link to the desktop is broken. (Windows only)
• Fix Landed on Version: 112
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor change which just reverts behaviour for dragging.

Note that this patch conflicts with bug 1806730 so that bug should land first.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9326152 [details]
WIP: Bug 1819760, don't modify extensions when trying to create a desktop shortcut, esr version

Approved for 102.10esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/852d429792ec