[CTW] untilCacheCondition should treat timeout as a test failure
Categories
(Core :: Disability Access APIs, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
Details
Attachments
(1 file)
In a11y browser tests, untilCacheCondition first checks the condition immediately. If the condition isn't met, it waits for a cache update (via an XPCOM observer topic) and tries again. If it doesn't receive a cache update within 5 seconds, it also tries again. We do this to avoid hanging forever and failing all future tests.
In some cases (usually due to a bug in the test, but sometimes in the engine), we might hit this timeout but the condition still passes. When this happens, there's no clear indication that untilCacheCondition timed out. The only way to figure this out is to look at the timestamps in the log. This can result in tests exceeding their timeout threshold, but this is really hard to diagnose.
I've been bitten by this several times now. I think we should flag a test failure if the timeout is reached.
|
Assignee | |
Comment 1•2 years ago
|
||
Otherwise, tests can take a very long time to run due to a bug without us realising that this is due to cache condition timeouts.
|
||
Updated•2 years ago
|
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db31cf17952c In a11y browser tests, treat a timeout in untilCacheCondition as a failure. r=eeejay
|
||
Comment 3•2 years ago
•
|
||
Backed out changeset db31cf17952c (bug 1819799) for causing ba failures at browser_caching_table.js and browser_caching_domnodeid.js
Backout: https://hg.mozilla.org/integration/autoland/rev/354784055c36bedd6d7d71016e10b5865a1f4b69
Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=408094778&repo=autoland&lineNumber=10035
https://treeherder.mozilla.org/logviewer?job_id=408094799&repo=autoland&lineNumber=6235
|
|
Assignee | |
Updated•2 years ago
|
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73c83fecb157 In a11y browser tests, treat a timeout in untilCacheCondition as a failure. r=eeejay
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•