18198 - new bookmarks are added to the bookmarks popup twice

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Claudius Gayle]

Overview Description:
	All new bookmarks are added to the bookmarks popup twice. They are
added to the menu once and the Manage Bookmarks view just once.

Steps to Reproduce:

1) Pull down the Bookmarks popup once FIRST. This'll take 3 tries (bug 18197);
dismiss it.
2) Add a new bookmark. Bookmarks|Add Current page.
3) Now click the bookmarks popup again note the double entry.

Actual Results:
	The new bookmark is added twice to the popup list but only once elsewhere.
*Note, if you add a bookmark without ever having looked at the popup, it will only
be added once to the popup list, go figure.


Expected Results:
	each entry should only be added once everywhere.


Build Date & Platform Bug Found:
	This bug is XP and repro'd on all platforms with the 1999110709 builds.

not sure whose this is hence the cc'age.

Comment 1

[Peter Trudelle]

Another personal-toolbar-bookmarks-popup-specific menu bug, reassigning to slamm
for triage.  cc don

Comment 2

[Matthew Tuck [:CodeMachine]]

*** Bug 17717 has been marked as a duplicate of this bug. ***

Comment 3

[Steve Lamm]

Easily reproduced. Hopefully the fix to this is related to bug 18197.

Comment 4

[Steve Lamm]

This bug has the same cause as 18197.

Comment 5

[Claudius Gayle]

this is no longer broken, although bug 18197 is still an issue. Marking FIXED.

Comment 6

[Paul MacQuiddy]

and marking verified

Comment 7

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/4fb690b1e7ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18198 - Add a feature flag for Credit Cards and Addresses autofill feature (https://github.com/mozilla-mobile/fenix/pull/18200)