1819814 - Fenix doesn't set screen orientation even if fullscreen when replaying video

Status: RESOLVED FIXED

(GeckoView :: Media, defect, P1)

Description

[Makoto Kato [:m_kato]]

Environment

Fenix 109

Step

1. Open https://test-videos.co.uk/vids/bigbuckbunny/mp4/h264/1080/Big_Buck_Bunny_1080_10s_1MB.mp4, then video is auto-played
2. Tap full screen icon . Fenix continues to play this video by fullscreen and screen changes to landscape orientation
3. Wait for finished
4. Tap full screen icon

Result

screen keeps portrait orientation. Then when playing video again, orientation isn't changed.

If Step 3 is paused, Step4 is that screen changes to landscape orientation.

Excepted result

screen should be landscape orientation, or when playing video again, orientation isn't changed.

Notes

This issue is GeckoView side. GeckoView doesn't call media session delegate's onFullscreen() due to race condition of activated and fullscreen.

Also, GVE doesn't set media session delegate, there is no way to test this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1819814 - Call MediaSession.Delegate.onFullscreen correctly when entering full screen. r=#geckoview-reviewers

This is a race condition of full screen event and activated event of media
controller.

Media controller will dispatch activated event when full screen button is
clicked on controller. But since this depends on full screen event, if
GeckoView's media session receives this event before controller fires activated
event, MediaSession.Delegate.onFullscreen won't be called because
MediaSession.isActive() is false at this time.

So I would like to retry GeckoView:MediaSession:Fullscreen call when
entering full screen and controller isn't active yet.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cf8d96b3f03
Call MediaSession.Delegate.onFullscreen correctly when entering full screen. r=geckoview-reviewers,calu

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4cf8d96b3f03

Comment 5

[Kelimutu [:kiki]]

Attachment: Screenshot 2023-05-24 at 22-35-43 Closed - Agent Workspace.png

The Support team still seeing people experience the issue even after they updated to v113. Here's one of them.

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Kelimutu [:kiki] from comment #5)

Created attachment 9335688 [details]
Screenshot 2023-05-24 at 22-35-43 Closed - Agent Workspace.png

The Support team still seeing people experience the issue even after they updated to v113. Here's one of them.

Another bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=1827583