1819899 - siteDataTestUtils.hasCookies() is wrong if the host is a substring of an existing cookies host

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P3)

Description

[Hannah Peuckmann]

I encountered the issue that I set a cookies for "https://1hour10minutes.com" and for "https://10minutes.com", via siteDataTestUtils.addToCookie, and after I removed the cookie for "https://10minutes.com", siteDataTestUtils.hasCookies still stated that there is a cookie for "https://10minutes.com". I am quite sure that this is due to this includes statement here, "10minutes.com" is included in the string "1hour10minutes.com"

Comment 1

[Hannah Peuckmann]

@pbz do you think we could just check for equality of the hosts here or would that be too strict?

Comment 2

[Emma Zühlcke [:emz]]

That would be too strict. There may be cookies set for the entire base domain. We could call getCookiesFromHost instead: https://searchfox.org/mozilla-central/rev/dcf64fc565e3749119bd57202e2ab06533155d16/netwerk/cookie/nsICookieManager.idl#282

Comment 3

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1819899 - Avoid host substring matching in SiteDataTestUtils.hasCookies. r=pbz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b1c52a243d0
Avoid host substring matching in SiteDataTestUtils.hasCookies. r=anti-tracking-reviewers,pbz

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2b1c52a243d0