1819923 - Fix wpt failure in perform-microtask-checkpoint-before-construction-xml-parser.xhtml

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

wpt.fyi result https://wpt.fyi/results/custom-elements/perform-microtask-checkpoint-before-construction-xml-parser.xhtml?label=experimental&label=master&aligned

Comment 1

[Peter Van der Beken [:peterv]]

I took a quick look. For HTML we do this in nsHtml5TreeOperation::CreateHTMLElement. For XML we should do something similar in nsXMLContentSink::CreateElement.

We should probably add an mozilla::dom::CustomElementDefinition* aDefinition=nullptr argument to NS_NewElement, which can then forward it to NS_NewHTMLElement and NS_NewXULElement. In nsXMLContentSink::CreateElement we look up the CustomElementDefinition with nsContentUtils::LookupCustomElementDefinition, add an nsAutoMicroTask and AutoCEReaction if there is a CustomElementDefinition and pass it on to NS_NewElement. I think that might be enough. Olly and I think it should be fine to run script at this point, but of course we should run the whole testsuite.

Comment 2

[Adam Vandolder [:avandolder]]

Attachment: Bug 1819923 - Perform microtask checkpoint before custom element construction in XML documents. r?peterv,#dom-core

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93bb462dd37c
Perform microtask checkpoint before custom element construction in XML documents. r=peterv,dom-core

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_UrlbarInput_searchTerms_searchBar.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/77a354de11e22ddd10874d06a7e8c72701450148

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=93bb462dd37ccdf90020f99513ba476aef75f751&selectedTaskRun=Heof_MfgShe36vXXhGv1wQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=444549290&repo=autoland&lineNumber=4441
https://treeherder.mozilla.org/logviewer?job_id=444549272&repo=autoland&lineNumber=3022
https://treeherder.mozilla.org/logviewer?job_id=444553360&repo=autoland&lineNumber=7049
https://treeherder.mozilla.org/logviewer?job_id=444552779&repo=autoland&lineNumber=3481
https://treeherder.mozilla.org/logviewer?job_id=444550904&repo=autoland&lineNumber=13721

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef129d948041
Perform microtask checkpoint before custom element construction in XML documents. r=peterv,dom-core

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ef129d948041