1819940 - Remove expired extensions related telemetry probes

Status: RESOLVED FIXED

(WebExtensions :: General, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

We noticed a couple of probes related to extensions that have expired quite some time ago while we were looking into renewing some probe as part of Bug 1817103, in particular the following ones:

• histogram EXTENSION_INSTALL_PROMPT_RESULT
• histogram EXTENSION_UPDATE_TYPE
• scalar extensions.updates.rdf

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1819940 - Remove expired Scalar extensions.updates.rdf. r?willdurand!

Depends on D171114

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1819940 - Remove expired histogram EXTENSION_UPDATE_TYPE. r?willdurand!

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1819940 - Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r?willdurand!

Depends on D171112

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39c2d3bf84a2
Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/234b68df6453
Remove expired histogram EXTENSION_UPDATE_TYPE. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/1bcff70fd329
Remove expired Scalar extensions.updates.rdf. r=willdurand

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/39c2d3bf84a2
https://hg.mozilla.org/mozilla-central/rev/234b68df6453
https://hg.mozilla.org/mozilla-central/rev/1bcff70fd329

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing Bug 1820248 and Bug 1820250 as requested by dev.

• Backout link

Comment 7

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/da070069775f

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Serban Stanca from comment #6)

Backed out for causing Bug 1820248 and Bug 1820250 as requested by dev.

• Backout link

It looks like the test still failed with a timeout after Bug 1819940 got backed out:

• https://treeherder.mozilla.org/logviewer?job_id=407812428&repo=mozilla-central&lineNumber=10889

And I took a more deeper look into this, after trying to move back into the into the patches in the same push as Bug 1819940 I noticed that the test didn't fail anymore with my local clone working tree pointed on "Bug 1805288 - Part 1: Add ChromeUtils.defineLazyGetter. r?smaug", and so without the second patch applied "Bug 1805288 - Part 2: Use ChromeUtils.defineLazyGetter from XPCOMUtils.defineLazyGetter. r?smaug".

I'm not sure why the quick hg bisect that I did yesterday was still pointing to the patches attached to this bug, but I have been able to confirm that
"Bug 1805288 - Part 2" was the actual regression of those tests, and these 3 patches don't have anything to do with those two perma failures, on today's mozilla-central tip (where the patches attached to this bug are already all backed out) using the artifact builds and temporarily reverting "Bug 1805288 - Part 2":

# confirm first that the test fails in mozilla-central tip
./mach mochitest --headless editor/spellchecker/tests/test_bug1209414.html
   ... test get stuck and timeouts (consistently on every run) 

# then revert Bug 1805288 - Part 2
curl -sSL https://hg.mozilla.org/try/raw-rev/4d17103dd27759f3e3f8e76a5072831c6a95ef6a | patch -p1 -R

# try again to confirm that it does passes
./mach mochitest --headless editor/spellchecker/tests/test_bug1209414.html
   ... test passes and doesn't timeout (consistently on every run) 

Given that what I described in comment X provide me enough confirmation that the 3 patches are not related to the issue, I'll land them again next week.

The additional details described above should be also useful to update Bug 1820248 and Bug 1820250 accordingly (e.g. to update the regressing bug linked along with reopening them).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/691295217cf9
Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/0ea9fc3e88f3
Remove expired histogram EXTENSION_UPDATE_TYPE. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/08b44c2b85a2
Remove expired Scalar extensions.updates.rdf. r=willdurand

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/691295217cf9
https://hg.mozilla.org/mozilla-central/rev/0ea9fc3e88f3
https://hg.mozilla.org/mozilla-central/rev/08b44c2b85a2