1819952 - Give some WebRTC Destroy runnables better names

Status: RESOLVED FIXED

(Core :: WebRTC, task)

Description

[Andrew McCreight [:mccr8]]

There are a few uses of NewNonOwningRunnableMethod in WebRTC that pass __func__ in methods called "Destroy" which is a very common name. The drawback is that if the runnable leaks, as seen in bug 1775056, it can be hard to figure out what this even is.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1819952 - Give some WebRTC Destroy runnables better names.

Comment 2

[Andrew McCreight [:mccr8]]

I think I've audited every one of the runnable creating methods in nsThreadUtils, and these three in WebRTC seem to be the only instances in a method named Destroy that is using func.

Comment 3

[Andrew McCreight [:mccr8]]

(eg the other ones have the class name as well)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/259e1aeae776
Give some WebRTC Destroy runnables better names. r=bwc

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/259e1aeae776