1819988 - PiP's subtitle settings panel should close when pressing ESC

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, enhancement)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user uses keyboard navigation to navigate through the pip's subtitle settings, then presses ESC to close the panel, he will notice that ESC will close the entire PiP window.

Found in

• Nightly v112.0a1

Affected versions

• Nightly v112.0a1
• Release v110.1

Tested platforms

• Affected platforms: Windows 10, Ubuntu 22, MacOS 11
• Unaffected platforms: -

Steps to reproduce

1. Play any video with subs
2. Launch the Pip
3. Use keyboard navigation to modify subtitle settings
   a. Press TAB to focus the PiP's Subtitle settings button
   b. Press SPACEBAR to open the pannel
   c. Press TAB to focus elements inside the panel
   d. Press ESC

Expected result

• The Subtitle settings panel closes

Actual result

• The PiP window closes altogether

Regression range

• Not a recent regression.

Additional notes

• The user CAN close the panel by keyboard navigation, but he needs focus the subtitle settings button again, which takes a few TAB presses and then press SPACEBAR/ENTER.

Comment 1

[kpatenio]

Bug 1820141, once fixed, will allow closing the subtitles panel using ESC.

Comment 2

[kpatenio]

ESC key to close the subtitles panel should now be in Nightly 114. Marking this as fixed.

Comment 3

[Daniel Bodea [:danibodea]]

This fix has been verified and confirmed on Windows 10, Ubuntu 22 and MacOS 11 with Nightly v114.0a1.