1820042 - Calling bug->update twice on the same bug object is generally a bad idea so we load a second copy during the uplift process

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[David Lawrence [:dkl]]

When PhabBugz performs changes for an uplift request in Phabricator, it loads the related bug and adds a new formatted comment. If needed it also adds a qe-verify flag. Currently the code calls $bug->update twice which is failing cause it is trying to perform some changes more than once and so we cannot do that.

I am going to create a patch that loads a fresh copy of the bug if a qe-verify flag is needed and then do the second update to that.

Comment 1

[BMO Automation]

Attachment: [mozilla-bteam/bmo] Bug 1820042 - Calling bug->update twice on the same bug object is generally a bad idea so we load a second copy during the uplift process (#2022)

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/2bdf18d061604374a7f485cee2c353359021f4c7