Do something sensible when displaying messages that are unavailable offline
Categories
(Thunderbird :: Message Reader UI, defect)
Tracking
(thunderbird111 fixed)
Tracking | Status | |
---|---|---|
thunderbird111 | --- | fixed |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
|
Details | Review |
When offline and without messages synchronised, this code calling DisplayMessage gets an exception from the back-end, and nothing happens. The previously displayed message is still displayed. We should remove it and show a message about things being unavailable.
I don't think this is quite the same problem as the message being unavailable because it hasn't synchronised yet, but that is also problematic.
Assignee | ||
Comment 1•7 months ago
|
||
This just replaces the error message as it was before, no attempt has been made to make it pretty or use sensible strings.
I have however changed how the error works, it is now dealt with at the front-end when the back-end returns NS_ERROR_OFFLINE, instead of the back-end trying to deal with it.
Assignee | ||
Updated•7 months ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2736faf3b34c
Restore "message unavailable offline" error message. r=mkmelin
Assignee | ||
Updated•7 months ago
|
Comment 3•7 months ago
|
||
Comment on attachment 9321246 [details]
Bug 1820080 - Restore "message unavailable offline" error message. r=#thunderbird-reviewers
[Triage Comment]
Approved for beta
Comment 4•7 months ago
|
||
bugherder uplift |
Thunderbird 111.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/03381f289dee
Description
•