1820081 - Some providers happen error when paste-and-go and drag-and-go

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Daisuke Akatsuka (:daisuke)]

This is regressed by bug 1817155.
When paste-and-go or drop-and-go on the urlbar, the following errors happen.

console.error: (new TypeError("can't access property \"view\", queryContext is undefined", "resource:///modules/UrlbarProviderQuickActions.sys.mjs", 278))
console.error: (new TypeError("can't access property \"view\", queryContext is undefined", "resource:///modules/UrlbarProviderQuickSuggest.sys.mjs", 371))
console.error: (new TypeError("can't access property \"view\", queryContext is undefined", "resource:///modules/UrlbarProviderWeather.sys.mjs", 433))

We cleared UrlbarController.sys._lastQueryContextWrapper when both actions, but that we are touching its context in their providers is the reason.

• paste-and-go https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarInput.sys.mjs#2811
• drop-and-go https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarInput.sys.mjs#3643

We need to fix it.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1820081: Correspond to cleared query context when paste-and-go and drop-and-go

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1817155

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b33cd14f85d
Correspond to cleared query context when paste-and-go and drop-and-go r=adw

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5b33cd14f85d

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx 113.0a1 on WIndows 10 and Ubuntu 20.04. There are no longer any errors logged into the console on paste & go and drag & drop operations. Also, the searches are performed without any issues.