Closed
Bug 1820081
Opened 3 months ago
Closed 3 months ago
Some providers happen error when paste-and-go and drag-and-go
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
112 Branch
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox110 | --- | unaffected |
firefox111 | --- | unaffected |
firefox112 | --- | verified |
firefox113 | --- | verified |
People
(Reporter: daisuke, Assigned: daisuke)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
This is regressed by bug 1817155.
When paste-and-go or drop-and-go on the urlbar, the following errors happen.
console.error: (new TypeError("can't access property \"view\", queryContext is undefined", "resource:///modules/UrlbarProviderQuickActions.sys.mjs", 278))
console.error: (new TypeError("can't access property \"view\", queryContext is undefined", "resource:///modules/UrlbarProviderQuickSuggest.sys.mjs", 371))
console.error: (new TypeError("can't access property \"view\", queryContext is undefined", "resource:///modules/UrlbarProviderWeather.sys.mjs", 433))
We cleared UrlbarController.sys._lastQueryContextWrapper
when both actions, but that we are touching its context in their providers is the reason.
- paste-and-go https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarInput.sys.mjs#2811
- drop-and-go https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarInput.sys.mjs#3643
We need to fix it.
Assignee | ||
Comment 1•3 months ago
|
||
Comment 2•3 months ago
|
||
Set release status flags based on info from the regressing bug 1817155
status-firefox110:
--- → unaffected
status-firefox111:
--- → unaffected
status-firefox112:
--- → affected
status-firefox-esr102:
--- → unaffected
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b33cd14f85d Correspond to cleared query context when paste-and-go and drop-and-go r=adw
Comment 4•3 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Comment 5•2 months ago
|
||
The issue is verified fixed using the latest Fx 113.0a1 on WIndows 10 and Ubuntu 20.04. There are no longer any errors logged into the console on paste & go and drag & drop operations. Also, the searches are performed without any issues.
You need to log in
before you can comment on or make changes to this bug.
Description
•