1820158 - Support main WEBEXT_* telemetry histograms probes on GeckoView

Status: RESOLVED FIXED

(WebExtensions :: Android, task, P2)

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1820158 - Port WEBEXT_* timing histograms to Glean timing_distribution metrics. r?zombie!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1820158 - Fix test_ext_storage_telemetry.js failure when executed with extensions running in the parent process. r?zombie!

Depends on D191699

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1820158 - Fix test_ext_extension_content_telemetry.js failure when executed with extensions running in the parent process. r?zombie!

Depends on D191700

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1820158 - Port WEBEXT_EVENTPAGE_RUNNING_TIME_MS to Glean custom_distribution metric. r?zombie!

Depends on D191743

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1820158 - Port WEBEXT_EVENTPAGE_IDLE_RESULT_COUNT and WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT to Glean labeled_counter metrics. r?zombie!

Depends on D191752

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: bug1820158_request_port_WEBEXT_histograms_to_glean_metrics.md

Hi Chris,
as I'm also mentioning in a note inside the markdown I'm attaching through this comment, technically this bugzilla issue is about porting some of our existing histograms from the unified telemetry probes to Glean metrics, it doesn't seem we have a specific data review form for porting existing metrics to Glean but given that these probes already exists in our unified telemetry and the data review request
would end up being the same as the one attached when each of these histograms have been added
it felt like the renewal request form would fit better.

Let me know if you think we should instead create a data review request using the data review request template instead, and I'll mark this as obsolete and prepare to fill that kind of form instead.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try: https://treeherder.mozilla.org/jobs?repo=try&revision=f8e1f811f906ba27508014f29830c3ab546a3642

Comment 8

[Chris H-C :chutten]

Comment on attachment 9360088 [details]
bug1820158_request_port_WEBEXT_histograms_to_glean_metrics.md

Ah, if these collections already have data collection review, then you may just use those existing data collection reviews.

But I'll mark this as data-review+ instead of obsolete so if anyone finds their way here they can follow the links in your comprehensive review request to the original reviews if they desire.

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try of the patches attached to this bugzilla issue with the last round of changes applied today:

• https://treeherder.mozilla.org/jobs?repo=try&revision=ca10be42fff79919dbd218babf2045aa59370590

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f01ac68dcbd5
Port WEBEXT_* timing histograms to Glean timing_distribution metrics. r=zombie
https://hg.mozilla.org/integration/autoland/rev/6a018a213156
Fix test_ext_storage_telemetry.js failure when executed with extensions running in the parent process. r=zombie
https://hg.mozilla.org/integration/autoland/rev/253d9b552e03
Fix test_ext_extension_content_telemetry.js failure when executed with extensions running in the parent process. r=zombie
https://hg.mozilla.org/integration/autoland/rev/f29ffb8906a0
Port WEBEXT_EVENTPAGE_RUNNING_TIME_MS to Glean custom_distribution metric. r=zombie
https://hg.mozilla.org/integration/autoland/rev/d2f37b836b41
Port WEBEXT_EVENTPAGE_IDLE_RESULT_COUNT and WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT to Glean labeled_counter metrics. r=zombie

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f01ac68dcbd5
https://hg.mozilla.org/mozilla-central/rev/6a018a213156
https://hg.mozilla.org/mozilla-central/rev/253d9b552e03
https://hg.mozilla.org/mozilla-central/rev/f29ffb8906a0
https://hg.mozilla.org/mozilla-central/rev/d2f37b836b41