1820211 - Add telemetry for detected tab kills with form data

Status: VERIFIED FIXED

(Fenix :: Browser Engine, task, P1)

Description

[Cathy Lu [:calu]]

Add telemetry to Fenix to know if a tab has unsubmitted form data when it is killed. This will let us know what percentage of user-affected kills fall in this situation.

Store the result of whether or not we have form data as part of the tab state, and report that when tab kills are recorded (https://github.com/mozilla-mobile/firefox-android/blob/main/fenix/app/src/main/java/org/mozilla/fenix/telemetry/TelemetryMiddleware.kt#L122-L128).

Comment 1

[Cathy Lu [:calu]]

If the percentage is high, we should add this feature to private sessions as well.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1820211 - Adds `tabKilled` event to track when a tab was killed with form data. (#1343)

Comment 3

[BMO Github Automation]

Authored by https://github.com/boek
https://github.com/mozilla-mobile/firefox-android/commit/7da21ab3f90f01432ea7c1b50806f68510567b39
[main] Bug 1820211 - Adds `tabKilled` event to track when a tab was killed with form data. (#1343)

Comment 4

[Delia Pop]

Hello, :boek,
I attempted to verify this ticket by closing tabs and closing the app (with both the app in background and foreground) while having unsubmitted forms , however I was not able to capture the telemetry metrics engine_tab.kill_background_age, engine_tab.kill_foreground_age or engine_tab.kills as they appear in the Glean Dictionary.
I was wondering if there's another way to verify this or if testing from the QA team is needed at all. Please let us know your input on this.

Comment 5

[Jeff Boek [:boek]]

Hello! So the only time this happens is if the tab is killed. The way that I tested it was by running adb shell dumpsys meminfo to find the PID of the running tab and then following it up with adb shell kill <PID>.

Comment 6

[miralobontiu]

Thank you, Jeff!
We were not able to trigger the tab "kill" when using the command adb shell kill <PID> - we received the "Operation not permitted" message in Command prompt. We tried also on a debug build, still unsuccessfully.

Is there a different scenario we can try?
Thank you!

Comment 7

[miralobontiu]

We were able to generate the following events/metrics on the Fenix Nightly 114.0a1 from 4/12:

• engine_tab.kill_background_age
• engine_tab.kill_foreground_age
• engine_tab.kills
• engine_tab.tab_killed

Glean dashbord - metrics
Glean dashboard - event