1820292 - Convert <label is="text-link"> to HTML anchor in about:preferences#sync

Status: RESOLVED DUPLICATE of bug 1821086

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

Attachment: Connect another device link.png

There's a "Connect another device" link in about:preferences#sync that's currently using <label is="text-link"> but should be pretty straightforward to convert to use an anchor. See the attached image for more context.

To help Mozilla out with this bug, follow these steps:

1. Comment here on the bug that you want to volunteer to help. This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Firefox Contributors' Quick Reference, which has answers to most development questions.
3. Start working on this bug.
   • To find the dialog in Firefox, navigate to about:preferences#sync. In order to see this link and ensure it's working as expected you will likely have to sign up for a Firefox account and sign in. Instructions on how to do that can be found here.
   • The code for the link can be found here.
   • There's another anchor in the same file that can be used as a reference for what we're trying to do.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your changes locally. Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • Getting your code reviewed
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!

Comment 1

[tosinsajo]

I'm looking into bug and working on the next steps to correct the link with <label is="text-link"> to use an anchor

Comment 2

[Hanna Jones [:hjones]]

Great, thanks! I've gone ahead and set you as the assignee for this bug. You should be able to get set up and started on the bug by following the steps in my first comment. If you run into any issues or have questions you can request information from me using the form below, or reach out to me and my teammates in #reusable-components on Matrix.

Comment 3

[tosinsajo]

<a id="connect-another-device"
class="text-link fxaMobilePromo"
data-l10n-id="sync-connect-another-device">
Connect Another Device
</a>

:
this is the change i wish to make but i'm having issues setting up mozilla build and I'm a bit lost on what exactly the process would be like to set it up
i would appreciate an explanation
I've left you a mail of my screen
thank you

Comment 4

[Hanna Jones [:hjones]]

Hey, I believe I responded to your email, but let me know if you're still having issues with getting set up.

Your proposed code change looks like it's on the right track, thanks! One thing to note is you'll need to specify that this is an HTML anchor since this is in an xhtml document. You can do that by adding the html namespace to your code like this: <html:a ... />

You can see an example of how this was done a little higher up in that same file: https://searchfox.org/mozilla-central/source/browser/components/preferences/sync.inc.xhtml#82-83

Comment 5

[tosinsajo]

Attachment: Bug 1820292 - Convert <label is=text-link> to HTML anchor in about:preferences#sync. r=hjones

Comment 6

[tosinsajo]

Commit forwarded for review

Comment 7

[tosinsajo]

Attachment: Bug 1820292 Convert <label is=text-link> to HTML anchor in about:preferences#sync corrected r=hjones

Depends on D172521

Comment 8

[tosinsajo]

Attachment: Bug 1820292 Convert <label is=text-link> to HTML anchor in about:preferences#sync r=hjones

Depends on D172522

Comment 10

[Hanna Jones [:hjones]]

Hey :tosinsajo unfortunately this bug has already been fixed by code submitted for a different bug. Sorry about that! We try to avoid filing duplicate bugs, but it still happens sometimes. Let me know if you want help finding another bug to work on instead.

Comment 11

[tosinsajo]

(In reply to Hanna Jones [:hjones] from comment #10)
Thank you for letting me know and appreciate if you could suggest another bug for me to work on.

Comment 12

[Hanna Jones [:hjones]]

Hey :tosinsajo I've been mentoring on this bug but the applicant seems to have stopped participating. If you want to work on it feel free to submit a patch. Otherwise let me know if there's anything you would like to work on from this list and I can try to help you out.