1820511 - Rescaled image isn't drawn on the canvas when it has specific dimensions

Status: NEW

(Core :: Graphics: Canvas2D, defect)

Description

[Calixte Denizet (:calixte)]

Attachment: max_canvas.html

When opening the attachment a red square should be drawn but it isn't.
If I change the K value to -1 in the script then everything is fine.

In the pdf.js context we have sometimes large images embedded in the pdf and we've to downscale them.

Comment 1

[Calixte Denizet (:calixte)]

I can't reproduce the bug with nightly on either Mac or Fedora.

Comment 2

[Mayank Bansal]

On Windows11:
Repro with the D2d backend
Doesnt repro with gpu-canvas
Doesnt repro with skia-canvas

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1820511 - Avoid fallbacks in DrawTargetWebgl::CopySurface. r?aosmond

This implements some optimizations targeted at Canvas2D's putImageData:

1. Track whether the canvas is in the initially clear state so that we avoid
   reading back from the WebGL framebuffer into the Skia framebuffer when a
   fallback does occur or when a data snapshot is needed.

2. For surfaces that are too large to upload to a texture, directly use
   glTexSubImage2D to draw data to the WebGL framebuffer, bypassing a separate
   texture upload.

3. Disregard the surface size limits for SurfacePatterns containing a
   compatible texture handle.

Comment 4

[Phabricator Automation]

Comment on attachment 9321467 [details]
Bug 1820511 - Avoid fallbacks in DrawTargetWebgl::CopySurface. r?aosmond

Revision D171773 was moved to bug 1820546. Setting attachment 9321467 [details] to obsolete.

Comment 5

[Lee Salzman [:lsalzman]]

Oops, accidentally put wrong bug number in patch.

Comment 6

[Timothy Nikkel (:tnikkel)]

This seems to be fixed by bug 1759728?

Comment 7

[Calixte Denizet (:calixte)]

I can reproduce the issue with nightly (20230306211718) and gfx.max-alloc-size set to 2147483647.

Comment 8

[Calixte Denizet (:calixte)]

Attachment: big_width.html

I can reproduce the issue with big_width.html where only the width is bigger than 16384 and the height is 100 so it isn't a matter of total area.
I opened big_width.html in release and same problem so it isn't related to the fix in bug 1759728.

Comment 9

[Timothy Nikkel (:tnikkel)]

Ah, okay, so looks like this is about issues with the d2d backend of canvas then.